Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for integration #293

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

lextm
Copy link
Contributor

@lextm lextm commented Feb 26, 2022

Like discussed in #279 I will start to send pull requests to prepare the integration of esbonio with other extensions.

This initial one contains two changes,

  1. Changed the language ID so that it matches other extensions.
  2. Added some new code to detect if esbonio Python package has been installed. If not, it prompts the user to install it.

There are many more to come, and I will keep each pull request as small as possible for you to review.

@alcarney
Copy link
Member

Thanks for this!

However, I don’t think fe879c5 is necessary as there is already code in src/lsp/server.ts that handles installation and upgrades to the server - could you remove it?

@lextm
Copy link
Contributor Author

lextm commented Feb 26, 2022

Removed.

@alcarney alcarney merged commit c51085e into swyddfa:develop Feb 26, 2022
@lextm lextm deleted the language-id branch February 26, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants