Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Fix: task worker num output zero always and enable task worker when defined connections in queue.php #503

Merged
merged 4 commits into from
Sep 10, 2021

Conversation

m3m0r7
Copy link
Contributor

@m3m0r7 m3m0r7 commented Sep 10, 2021

I fixed:

  1. Task Worker Num is output zero always when using php artisan swoole:http infos.
    • because $this->config cannot access to queue.php.
  2. Did not start task worker (always unset the defined value) when defining connections in queue.php because the laravel-swoole refer queue.default only.

In my use-case, I want to set default SQS (AWS), but another way, I want to use swoole's task worker.
However, the laravel-swoole did not run task worker because the reason is above.

@Arkanius
Copy link
Contributor

Good job! This issues were never mentioned.

@Arkanius
Copy link
Contributor

I'll apply on the next release

@Arkanius Arkanius merged commit 29c6bfa into swooletw:master Sep 10, 2021
@m3m0r7 m3m0r7 deleted the fix-task-worker-for-queue branch September 11, 2021 08:12
@m3m0r7
Copy link
Contributor Author

m3m0r7 commented Sep 11, 2021

Thx!

@brainiac84
Copy link

@Arkanius If possible, please make a minor release with these changes. I ran into the same issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants