This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Recommit maybe a bug #475
Closed
Recommit maybe a bug #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This style of function declaration [has been deprecated in PHP 8.0](https://www.php.net/manual/en/migration80.deprecated.php).
Arkanius
suggested changes
Mar 19, 2021
| @@ -68,7 +68,7 @@ protected function __construct( | |||
| bool $broadcast, | |||
| bool $assigned, | |||
| string $event, | |||
| $message = null, | |||
| string $message, | |||
There was a problem hiding this comment.
looks it should be:
?string $messagenull is still the default option
There was a problem hiding this comment.
what? Put ? In front of string ? Doesn't this report an error?
There was a problem hiding this comment.
OHHH, I found it!. This is a new feature of PHP7.1. I had recommit a PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommit, add
stringtype to$message. This style of function declaration has been deprecated in PHP 8.0.solve issue: Is this a BUG?