Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Fix memory leak - clear context after disabling sandbox #381

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Fix memory leak - clear context after disabling sandbox #381

merged 1 commit into from
Mar 29, 2020

Conversation

geneccx
Copy link
Contributor

@geneccx geneccx commented Mar 3, 2020 •
edited
Loading

Calling Context::setApp after disabling the sandbox (which is supposed to clear the context) causes that entry to be set again in the $apps array. This leaks a booted app, since Coroutine::getuid() is monotonic.

@geneccx geneccx changed the title Fix memory leak - don't save context when disabling sandbox Fix memory leak - clear context after disabling sandbox Mar 3, 2020
@coveralls
Copy link

coveralls commented Mar 3, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 68.586% when pulling 3cf0cd9 on geneccx:fix-app-leak into e0e4c38 on swooletw:develop.

@albertcht
Copy link
Member

Hi @geneccx ,

Thanks for you pull request.

@albertcht albertcht merged commit db810ce into swooletw:develop Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geneccx @coveralls @albertcht