[6.0]support coroutine lock feature #5554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanFreeman
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5554 +/- ##
==========================================
- Coverage 70.84% 70.65% -0.20%
==========================================
Files 108 109 +1
Lines 16720 16764 +44
Branches 3057 3064 +7
==========================================
- Hits 11846 11844 -2
- Misses 4818 4864 +46
Partials 56 56 ☔ View full report in Codecov by Sentry. |
NathanFreeman
force-pushed
the
coroutine_lock_feature
branch
6 times, most recently
from
5f20841
to
e63515b
Compare
NathanFreeman
force-pushed
the
coroutine_lock_feature
branch
from
e63515b
to
ef2acc2
Compare
…into coroutine_lock_feature
matyhtf
requested changes
Nov 7, 2024
src/coroutine/iouring.cc
Outdated
| @@ -54,6 +58,9 @@ struct IouringEvent { | |||
| const char *pathname; | |||
| const char *pathname2; | |||
| struct statx *statxbuf; | |||
| #ifdef HAVE_IOURING_FUTEX | |||
| uint32_t *futex; | |||
There was a problem hiding this comment.
Can be unioned with other fields to save memory
src/coroutine/iouring.cc
Outdated
| #ifdef HAVE_IOURING_FUTEX | ||
| case SW_IORING_OP_FUTEX_WAIT: | ||
| case SW_IORING_OP_FUTEX_WAKE: | ||
| return "FUTEX"; |
| Coroutine *current_coroutine = Coroutine::get_current(); | ||
| if (current_coroutine == nullptr) { | ||
| swoole_warning("The coroutine lock can only be used in a coroutine environment"); | ||
| return 1; |
src/lock/coroutine_lock.cc
Outdated
| return 1; | ||
| } | ||
|
|
||
| result = Iouring::futex_wait((uint32_t *) value); |
There was a problem hiding this comment.
No check result is given. If the wait fails, it means that the lock ownership is not obtained.
…into coroutine_lock_feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.