Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for 8.4 #5537

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Fixed for 8.4 #5537

merged 4 commits into from
Oct 22, 2024

Conversation

remicollet
Copy link
Contributor

Minimal fix tested with 8.4.0RC2

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.90%. Comparing base (cc6afa5) to head (6a46e54).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5537      +/-   ##
==========================================
- Coverage   70.91%   70.90%   -0.02%     
==========================================
  Files         108      108              
  Lines       16715    16715              
  Branches     3061     3061              
==========================================
- Hits        11854    11852       -2     
- Misses       4805     4807       +2     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remicollet remicollet changed the title Fix #5536 remove unneeded include of php_pdo_int.h Fixed for 8.4 Oct 22, 2024
@remicollet remicollet force-pushed the issue-5536 branch 2 times, most recently from 41b402d to 8ddaec4 Compare October 22, 2024 08:50
@remicollet
Copy link
Contributor Author

In (rewritten) commit for exit call, I add a swoole_call_original_handler function to take benefit of the saved function handlers (the function prototype should be moved in some headers, but didn't find the right one)

@remicollet
Copy link
Contributor Author

Failures in CI seems related to deprecation in test code.

@matyhtf matyhtf merged commit 0f056b6 into swoole:master Oct 22, 2024
38 of 42 checks passed
@matyhtf
Copy link
Member

matyhtf commented Oct 22, 2024

Failures in CI seems related to deprecation in test code.

The output format of exceptions in PHP 8.4 has changed, so the unit tests need to be updated. I'm currently working on it.

@remicollet remicollet deleted the issue-5536 branch October 22, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants