fix: swoft-cloud/swoft/issues/1146 add try catch for coroutine comple…

…te handle
swoft-cloud · Apr 13, 2020 · da237cb · da237cb
1 parent e6428a5
commit da237cb
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 18 deletions.
diff --git a/src/bean/src/Container.php b/src/bean/src/Container.php
@@ -592,7 +592,9 @@ public function isSingleton(string $name): bool
      */
     public function destroyRequest(string $id): void
     {
-        unset($this->requestPool[$id]);
+        if (isset($this->requestPool[$id])) {
+            unset($this->requestPool[$id]);
+        }
     }
 
     /**
@@ -602,7 +604,9 @@ public function destroyRequest(string $id): void
      */
     public function destroySession(string $sid): void
     {
-        unset($this->sessionPool[$sid]);
+        if (isset($this->sessionPool[$sid])) {
+            unset($this->sessionPool[$sid]);
+        }
     }
 
     /**

diff --git a/src/bean/src/Listener/DestroyRequestListener.php b/src/bean/src/Listener/DestroyRequestListener.php
@@ -22,11 +22,11 @@ class DestroyRequestListener implements EventHandlerInterface
      */
     public function handle(EventInterface $event): void
     {
-        $id = (string)$event->getParam(0, '');
-        if (empty($id)) {
+        $id = $event->getParam(0, '');
+        if (!$id) {
             return;
         }
 
-        BeanFactory::destroyRequest($id);
+        BeanFactory::destroyRequest((string)$id);
     }
 }
diff --git a/src/framework/src/Listener/CoroutineCompleteListener.php b/src/framework/src/Listener/CoroutineCompleteListener.php
@@ -12,6 +12,7 @@
 use Swoft\Event\EventInterface;
 use Swoft\Log\Logger;
 use Swoft\SwoftEvent;
+use Throwable;
 use function bean;
 use function sgo;
 
@@ -47,24 +48,28 @@ public function handle(EventInterface $event): void
      */
     private function coroutineComplete(): void
     {
-        // Wait
-        Context::getWaitGroup()->wait();
-
         /* @var Logger $logger */
         $logger = bean('logger');
 
-        // Add notice log
-        if ($logger->isEnable()) {
-            $logger->appendNoticeLog();
-        }
+        try {
+            // Wait coroutine
+            Context::getWaitGroup()->wait();
 
-        // Coroutine destroy
-        Swoft::trigger(SwoftEvent::COROUTINE_DESTROY);
+            // Add notice log
+            if ($logger->isEnable()) {
+                $logger->appendNoticeLog();
+            }
 
-        // Destroy request bean
-        Swoft::trigger(BeanEvent::DESTROY_REQUEST, $this, Co::tid());
+            // Coroutine destroy
+            Swoft::trigger(SwoftEvent::COROUTINE_DESTROY);
+        } catch (Throwable $e) {
+            $logger->error('run coroutine complete handle error: ' . $e->getMessage());
+        } finally { // Use finally ensure context destroy
+            // Destroy request bean
+            Swoft::trigger(BeanEvent::DESTROY_REQUEST, $this, Co::tid());
 
-        // Destroy context
-        Context::destroy();
+            // Destroy context
+            Context::destroy();
+        }
     }
 }