Boreholes table #1440
Merged
Boreholes table #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschumpr
reviewed
Aug 14, 2024
tschumpr
reviewed
Aug 14, 2024
tschumpr
requested changes
Aug 14, 2024
tschumpr
reviewed
Aug 14, 2024
tschumpr
reviewed
Aug 14, 2024
tschumpr
reviewed
Aug 14, 2024
tschumpr
reviewed
Aug 14, 2024
Schriftgrösse ist gemäss UI Design im Figma, ich würde es mal so lassen. |
tschumpr
reviewed
Aug 14, 2024
Co-authored-by: Roswita Tschümperlin <[email protected]>
Die Schriftgrösse müsste, wenn wir nach Figma gehen, auch im Dialog auf 16px gesetzt werden. Evt. gleich übers Theme lösen (Body?). In der BottomBar wird zudem eine andere Schrift verwendet als in der Table. Vielleicht kann man das auch gleich noch vereinheitlichen. Dann passt es mit den Schriftgrössen besser zusammen. Könnte man die Schrift im RowCount auch noch anpassen? |
tschumpr
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#1322](#132
Habe noch ein Problem mit cypress tests die lokal laufen aber im Ci nicht 🤷♀️, aber ich gebe euch den PR schonmal zum review, da er recht fett geworden ist.