Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Clear Selected Asset in Search #340

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Hotfix: Clear Selected Asset in Search #340

merged 1 commit into from
Nov 7, 2024

Conversation

daniel-va
Copy link
Contributor

Rewrites the search effects to fix any remaining errors with the search parameters and to make handling the entire search easier.

Behaviour should not be changed from DEV.

@daniel-va daniel-va requested a review from TIL-EBP November 7, 2024 07:33
TIL-EBP
TIL-EBP requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@TIL-EBP TIL-EBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent looked at the code in detail but I found these two things whliplaying with the ui:

  • The filters are no longer written to the url
  • On reload, the selected asset is loaded again but removed form the url. This means it is lost on a second reload

@daniel-va daniel-va force-pushed the hotfix/clear-selected-asset branch from 3a0841a to c2a395d Compare November 7, 2024 08:58
@daniel-va daniel-va force-pushed the hotfix/clear-selected-asset branch 2 times, most recently from 5944eb0 to 4fba2b9 Compare November 7, 2024 12:05
@TIL-EBP TIL-EBP changed the base branch from develop to main November 7, 2024 12:18
@TIL-EBP TIL-EBP dismissed their stale review November 7, 2024 12:18

The base branch was changed.

@daniel-va daniel-va force-pushed the hotfix/clear-selected-asset branch from 4fba2b9 to ca14713 Compare November 7, 2024 12:25
@daniel-va daniel-va requested a review from TIL-EBP November 7, 2024 12:36
@TIL-EBP TIL-EBP force-pushed the hotfix/clear-selected-asset branch from ca14713 to da161c5 Compare November 7, 2024 12:44
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TIL-EBP TIL-EBP merged commit 5e5a594 into main Nov 7, 2024
1 check passed
@TIL-EBP TIL-EBP deleted the hotfix/clear-selected-asset branch November 7, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TIL-EBP TIL-EBP TIL-EBP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-va @TIL-EBP