Feature 70: add disclaimer #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-va
requested changes
Oct 23, 2024
apps/client-asset-sg/src/app/components/language-selector/language-selector.component.ts
Outdated
Show resolved
Hide resolved
apps/client-asset-sg/src/app/components/language-selector/language-selector.component.ts
Outdated
Show resolved
Hide resolved
apps/client-asset-sg/src/app/components/disclaimer-dialog/disclaimer-dialog.component.ts
Outdated
Show resolved
Hide resolved
apps/client-asset-sg/src/app/components/disclaimer-dialog/disclaimer-dialog.component.ts
Outdated
Show resolved
Hide resolved
apps/client-asset-sg/src/app/components/disclaimer-dialog/disclaimer-dialog.component.ts
Outdated
Show resolved
Hide resolved
apps/client-asset-sg/src/app/components/disclaimer-dialog/disclaimer-dialog.component.html
Outdated
Show resolved
Hide resolved
apps/client-asset-sg/src/app/components/app-bar/app-bar.component.html
Outdated
Show resolved
Hide resolved
daniel-va
requested changes
Oct 29, 2024
apps/client-asset-sg/src/app/components/disclaimer-dialog/disclaimer-dialog.component.scss
Show resolved
Hide resolved
apps/client-asset-sg/src/app/components/disclaimer-dialog/disclaimer-dialog.component.ts
Outdated
Show resolved
Hide resolved
daniel-va
approved these changes
Oct 30, 2024
apps/client-asset-sg/src/styles.scss
Outdated
Comment on lines
146
to
148
| .disclaimer-backdrop-color { | ||
| background-color: grey; | ||
| } |
There was a problem hiding this comment.
Move this back into the disclaimer CSS (using ::ng-deep) - Its not a problem to have "global" css in the component modules, as long as it is clean (i.e. as safe as possible) and commented as such.
Squash Commits before Merge! |
TIL-EBP
force-pushed
the
feature/assets-70-disclaimer
branch
2 times, most recently
from
83c6785 to
0f6694f
Compare
TIL-EBP
force-pushed
the
feature/assets-70-disclaimer
branch
from
0f6694f to
242868b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #70
to test, set
hideDisclaimerinenvironment.tstofalse