Fix: don't allow to update usage status or work status if not masterEditor

[TIL-EBP]

resolves #309

[daniel-va]

I have some issues with this function. Note that these are just general observations - if and how you apply them is up to you. Solving some of these issues even makes others obsolete.

• There is currently no reason for this to be a nested function (a function within another function). I like nested functions, as long as they reuse their outer scope, making their parameter list more readable. Here, the last three parameters are unnecessary - they can be replaced by accessing the outer function's scope.

• As a general rule, I like to keep a function's parameter count at a maximum of 3 or 4. Any more than that and it becomes unclear what each argument passed to the function does. If there is no way to reduce the parameter count, use an options object, e.g:

  const checkStatusChange = (hasChanged: boolean, options: {
    newStatus: string;
    allowedStatus: string;
    errorMessage: string;
  }) => { ... } 

  This makes function calls much more readable:

  checkStatusChange(hasInternalUseChanged, {
    newStatus: patch.internalUse.statusAssetUseItemCode,
    allowedStatus: 'tobechecked',
    errorMessage: 'Changing the asset's status is not allowed',
  })

• There is no reason for allowedStatus and errorMessage to be parameters, as they are the same for all function calls.

• Instead of passing hasChanged and newStatus, you could just pass the key 'internalUse' | 'publicUse'. This would also enable you to compute hasChanged within the function instead of duplicating it outside of it.

• Reading a function starting with check, I would expect it to return a value (a boolean, most likely). Here, I would prefer validateStatus to keep with the outer function's name, or even validateStatusOrThrow if you want to be explicit about what it does.
  If you want to keep it as a check*, I personally would prefer to make the function return a boolean and then make the function caller throw the exception themself. This would also enable you to remove the errorMessage parameter from the function, while keeping the function pure.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud