-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Search flow in NGRX to fix routing #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general remark:
When I start a search from the map page, then navigate to "Verrwaltung" and back to the map, the filters are closed. When I do the same via Benutzerverwaltung, the filters are open (as they should be IMO) This probably still has something to do with the portals which are still used in the "Verwatltungs"-Tab??
Nitpick: When hiding the results table, navigating away and back to map, the table is now open again. previously, this state was persisted
When I search by polygon and then reset the polygon ("Polygon aufheben") it takes much longer fot the search result to disappear than before. When going vis "Suche zurücksetzen", it is (still) almost instant
Not directly part of your PR, but i notived that when selecting an asset, navigatng to a different page and then navigtaing back to the map page, the asset is still selected, but the map zoom is not on focussed on this asset but the entire map. What is the desired behaviour there?
libs/asset-viewer/src/lib/state/asset-search/asset-search.effects.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still exists: Nitpick: When hiding the results table, navigating away and back to map, the table is now open again. previously, this state was persisted.
Other than that and my nitpick comments it looks good
libs/asset-viewer/src/lib/state/asset-search/asset-search.effects.ts
Outdated
Show resolved
Hide resolved
libs/asset-viewer/src/lib/state/asset-search/asset-search.effects.ts
Outdated
Show resolved
Hide resolved
apps/client-asset-sg/src/app/components/menu-bar/menu-bar.component.html
Outdated
Show resolved
Hide resolved
83d1d1b
to
3c712b9
Compare
06f2564
to
2f9aed4
Compare
Quality Gate passedIssues Measures |
Resolves #240