Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Search flow in NGRX to fix routing #267

Merged
merged 14 commits into from
Sep 16, 2024

Conversation

vej-ananas
Copy link
Contributor

Resolves #240

Copy link
Contributor

@TIL-EBP TIL-EBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general remark:

When I start a search from the map page, then navigate to "Verrwaltung" and back to the map, the filters are closed. When I do the same via Benutzerverwaltung, the filters are open (as they should be IMO) This probably still has something to do with the portals which are still used in the "Verwatltungs"-Tab??

Nitpick: When hiding the results table, navigating away and back to map, the table is now open again. previously, this state was persisted

When I search by polygon and then reset the polygon ("Polygon aufheben") it takes much longer fot the search result to disappear than before. When going vis "Suche zurücksetzen", it is (still) almost instant

Not directly part of your PR, but i notived that when selecting an asset, navigatng to a different page and then navigtaing back to the map page, the asset is still selected, but the map zoom is not on focussed on this asset but the entire map. What is the desired behaviour there?

@vej-ananas vej-ananas requested a review from TIL-EBP September 10, 2024 09:43
Copy link
Contributor

@TIL-EBP TIL-EBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still exists: Nitpick: When hiding the results table, navigating away and back to map, the table is now open again. previously, this state was persisted.

Other than that and my nitpick comments it looks good

@vej-ananas vej-ananas force-pushed the bug/assets-240_fix-routing branch from 83d1d1b to 3c712b9 Compare September 12, 2024 11:20
@vej-ananas vej-ananas force-pushed the bug/assets-240_fix-routing branch from 06f2564 to 2f9aed4 Compare September 12, 2024 11:44
Copy link

@vej-ananas vej-ananas merged commit 869bbb6 into develop Sep 16, 2024
6 checks passed
@vej-ananas vej-ananas deleted the bug/assets-240_fix-routing branch September 16, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Suche und URL out of Sync
2 participants