Feature 107: Refactor Backend Structure #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
daniel-va
force-pushed
the
feature/asset-107-backend-ordnerstruktur
branch
from
a5875a2 to
6cacb79
Compare
TIL-EBP
approved these changes
May 30, 2024
There was a problem hiding this comment.
IS this file/ the entire feature still required? now that the search is in the features/assets/search?
There was a problem hiding this comment.
Until #99 is finished, the old search is still in use. We will most likely need a cleanup issue afterwards to remove things like this file, but for now, it's still required.
| static parse(value: string): LocalDate { | ||
| const parts = value.split('-'); | ||
| if (parts.length !== 3) { | ||
| throw new Error(`failed to parse LocalDate (expected 3 parts, but got ${parts})`); |
|
|
||
| private constructor(date: Date) { | ||
| this.year = date.getFullYear(); | ||
| this.month = date.getMonth() + 1; |
There was a problem hiding this comment.
JavaScript's Date stores the month with a zero-based index (e.g. January = 0, December = 11, etc.). Everything else, i.e. days and years, are one-based. To use the same system for all three components, I increase the month when storing it in LocalDate.
# Conflicts: # apps/server-asset-sg/project.json # package.json Move app routes into specific features Collect user CRUD operations in `UserRepo` Update NestJs to `10.x` Add role guard Move user APIs into `/api/users` path Move contact routes into `/api/contacts` Refactor asset API Move NestJS utils into ` core` Fix `ElasticSearchAsset.titleOriginal` not supporting `null` values Fix `LocalDate.parse` error message
daniel-va
force-pushed
the
feature/asset-107-backend-ordnerstruktur
branch
from
b01c8b0 to
dc513da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107, resolves #129.
Restructures the backend (
server-asset-sg) by feature.fp-tsinto normal TypeScript interfaces. The main exceptions to this areasset-edit(now found in theasset-oldfeature) and the OCR file api.AppController, since the frontend still depends on it.*.repo.tsfile.