Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 29: Enable assigning multiple languages to a single asset #113

Merged
merged 6 commits into from
May 22, 2024

Conversation

daniel-va
Copy link
Contributor

@daniel-va daniel-va commented May 15, 2024

Solves #29 and #80.
Depends on #104.

  • Adds the table asset_language that enables many-to-many associations between asset and language_item
  • Updates all models and their usages on the server and client to work with the new table.
  • Updates the Elasticsearch index to store multiple languages per asset.

@daniel-va daniel-va requested a review from TIL-EBP May 15, 2024 14:48
@daniel-va daniel-va self-assigned this May 15, 2024
@daniel-va daniel-va requested a review from ga-ebp May 16, 2024 05:44
@daniel-va daniel-va force-pushed the feature/asset-29-multi-language branch 2 times, most recently from ea8f967 to 61144c2 Compare May 16, 2024 11:54
@vej-ananas vej-ananas linked an issue May 21, 2024 that may be closed by this pull request
@daniel-va daniel-va force-pushed the feature/asset-29-multi-language branch from 61144c2 to 2261b87 Compare May 22, 2024 09:29
@daniel-va daniel-va force-pushed the feature/asset-29-multi-language branch from 2261b87 to 2ed6ac2 Compare May 22, 2024 09:32
@daniel-va daniel-va force-pushed the feature/asset-29-multi-language branch from a4acdc2 to 4398e43 Compare May 22, 2024 10:46
Copy link
Contributor

@TIL-EBP TIL-EBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@daniel-va daniel-va merged commit 6476546 into develop May 22, 2024
10 checks passed
@daniel-va daniel-va deleted the feature/asset-29-multi-language branch May 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#29 Multi-Language | Elasticsearch
2 participants