Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): update mobile menu behaviour #4395

Open
wants to merge 5 commits into
base: 4326-update-megadropdown-styles
Choose a base branch
from
Open

fix(components): update mobile menu behaviour #4395

wants to merge 5 commits into from

Conversation

leagrdv
Copy link
Contributor

@leagrdv leagrdv commented Jan 7, 2025

No description provided.

@leagrdv leagrdv requested a review from a team as a code owner January 7, 2025 15:06
@leagrdv leagrdv requested review from gfellerph and removed request for a team January 7, 2025 15:06
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 2f1fe0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@leagrdv leagrdv changed the title chore(components): update mobile menu behaviour fix(components): update mobile menu behaviour Jan 7, 2025
@leagrdv leagrdv added the 🚂 PR train PR which follows another one. label Jan 7, 2025
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jan 7, 2025 •
edited
Loading

Related Previews

gfellerph
gfellerph requested changes Jan 10, 2025
View reviewed changes
packages/components/src/components/post-header/post-header.tsx
if (e.key === 'Tab') {
if (e.shiftKey && document.activeElement === this.firstFocusableEl) {
// If back tab (Tab + Shift) and first element is focused, focus goes to the last element of the megadropdown
e.preventDefault();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be done if the menu is open, otherwise it's impossible to go back to the logo and skiplinks:

image

Pressing [shift] + [tab] in this situation locks focus to the menu button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfellerph gfellerph gfellerph requested changes

Assignees
No one assigned
Labels
🚂 PR train PR which follows another one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leagrdv @swisspost-bot @gfellerph