Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tokens workflow #3954

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

alizedebray
Copy link
Contributor

@alizedebray alizedebray commented Nov 11, 2024

Updated the tokens PR workflow to:

  • have only one merging branch to prevent overriding changes from the current month with changes from the past month,
  • stop merging the main branch into the token branch, merge it into the merging branch instead

@alizedebray alizedebray requested a review from a team as a code owner November 11, 2024 10:29
Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: 3e6bc1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alizedebray alizedebray requested review from oliverschuerch and removed request for gfellerph November 13, 2024 08:58
Copy link

sonarcloud bot commented Nov 13, 2024

@alizedebray
Copy link
Contributor Author

alizedebray commented Nov 13, 2024

@oliverschuerch
I implemented the solution you suggested: 1deaf1b
The only thing is that it closes the current PR and opens an new one anytime changes are pushed to the tokens branch, which will happen multiple times a day, thereofre the PR numbers add up.

I also created this version that only updates the existing PR: 82b57a3
It merges the token branch into the PR branch using -X theirs to accept their changes in case of conflicts, then merges the main branch into the PR branch using -X ours.

With both solutions, the tokens branch remain untouched.

Can you please have a look at both solutions and give me your feedback on which one we should use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant