Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): segmented-button #3879

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat(components): segmented-button #3879

wants to merge 21 commits into from
+313 −7

Conversation

alionazherdetska
Copy link
Contributor

No description provided.

@alionazherdetska alionazherdetska requested review from a team as code owners November 5, 2024 09:22
@alionazherdetska alionazherdetska linked an issue Nov 5, 2024 that may be closed by this pull request
[component]: Segmented button #3460
Open
3 tasks
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cbca5a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 5, 2024 •
edited
Loading

Related Previews

oliverschuerch
oliverschuerch reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could group the docs for this in a buttons folder in the docs (together with all the other button components).

@oliverschuerch oliverschuerch marked this pull request as draft November 15, 2024 06:08
@oliverschuerch oliverschuerch requested review from gfellerph and removed request for oliverschuerch November 15, 2024 10:25
@oliverschuerch oliverschuerch requested review from alizedebray and oliverschuerch and removed request for oliverschuerch November 15, 2024 10:25
@oliverschuerch
Copy link
Contributor

@alionazherdetska please ask the team how many buttons should be available (max) in this component and document this in storybook.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@oliverschuerch oliverschuerch marked this pull request as ready for review November 15, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch oliverschuerch left review comments

@gfellerph gfellerph Awaiting requested review from gfellerph

@alizedebray alizedebray Awaiting requested review from alizedebray

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[component]: Segmented button
3 participants
@alionazherdetska @swisspost-bot @oliverschuerch