Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): remove deprecated line height variables #3521

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

veyaromain
Copy link
Contributor

No description provided.

@veyaromain veyaromain requested a review from a team as a code owner September 10, 2024 11:38
@veyaromain veyaromain linked an issue Sep 10, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 96b1426

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@swisspost/design-system-styles Major
@swisspost/design-system-documentation Minor
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Major
@swisspost/design-system-demo Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Major
@swisspost/design-system-styles-primeng Major
@swisspost/design-system-components-react Major
@swisspost/design-system-components-angular Major
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Major
@swisspost/design-system-icons Major
@swisspost/design-system-migrations Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Sep 10, 2024

Related Previews

@veyaromain veyaromain changed the title 1305 remove deprecated line height variables feat(styles): remove deprecated line height variables Sep 10, 2024
@alizedebray alizedebray requested review from alizedebray and removed request for oliverschuerch September 10, 2024 11:51
Copy link

sonarcloud bot commented Sep 10, 2024

Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first PR for the Design System 👏

@veyaromain veyaromain merged commit 006bc53 into main Sep 10, 2024
12 checks passed
@veyaromain veyaromain deleted the 1305-remove-deprecated-line-height-variables branch September 10, 2024 13:49
gfellerph pushed a commit that referenced this pull request Sep 13, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`main` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `main`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @swisspost/[email protected]

### Major Changes

- Removed deprecated `datatable` variables. (by
[@schaertim](https://github.com/schaertim) with
[#3395](#3395))

- Removed deprecated `display-size` variables. (by
[@schaertim](https://github.com/schaertim) with
[#3430](#3430))

- Removed deprecated `line-height-calc` function. (by
[@schaertim](https://github.com/schaertim) with
[#3409](#3409))

- Removed deprecated `form-check` variables. (by
[@schaertim](https://github.com/schaertim) with
[#3393](#3393))

- Removed deprecated `stepper` variables. (by
[@schaertim](https://github.com/schaertim) with
[#3394](#3394))

- Removed deprecated line-height variables. (by
[@veyaromain](https://github.com/veyaromain) with
[#3521](#3521))

### Minor Changes

- Added tokens file for elements, components and utilties. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#3495](#3495))

### Patch Changes

- Improved accessibility of headings with subheadings by removing the
<br> element and added the utility class d-block. Consult
<https://design-system.post.ch/?path=/docs/7ecd87f1-de96-4e39-a057-ba1798eb6959--docs>
for updated markup. (by [@bashirkarimi](https://github.com/bashirkarimi)
with [#3491](#3491))

- Aligned chip styles with the latest design specifications from Figma.
(by [@schaertim](https://github.com/schaertim) with
[#3463](#3463))

- Resolved issue where validation message icons repeated on each line of
multi-line messages. Implemented flexbox layout to ensure a single,
vertically centered icon regardless of message length. (by
[@schaertim](https://github.com/schaertim) with
[#3517](#3517))

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Applied High Contrast Mode mixin to breadcrumb SVGs for proper color
inversion. (by [@schaertim](https://github.com/schaertim) with
[#3480](#3480))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]



## @swisspost/[email protected]



## @swisspost/[email protected]

### Major Changes

- Removed the Monospace font from the typography page of the
documentation (will not be available once Bootstrap isn't included
anymore). (by [@schaertim](https://github.com/schaertim) with
[#3384](#3384))

### Minor Changes

- Removed deprecated line-height variables. (by
[@veyaromain](https://github.com/veyaromain) with
[#3521](#3521))

### Patch Changes

- Improved accessibility of headings with subheadings by removing the
<br> element and added the utility class d-block. Consult
<https://design-system.post.ch/?path=/docs/7ecd87f1-de96-4e39-a057-ba1798eb6959--docs>
for updated markup. (by [@bashirkarimi](https://github.com/bashirkarimi)
with [#3491](#3491))

- Refactored the stepper component to handle `updateArgs` directly
within the `getStepperItem` function, fixing the issue where stepper
examples were not independent and resolving unreliable step changes that
sometimes caused clicks to be unrecognized or froze the page. (by
[@schaertim](https://github.com/schaertim) with
[#3499](#3499))

- Removed disabling of the button in the "Good form example" of the
accessibility documentation. Repeated requests should be handled
internally as described in the accessibility documentation. (by
[@schaertim](https://github.com/schaertim) with
[#3403](#3403))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated line-height variables
3 participants