Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(documentation): implement new docs styles and webfonts #3161

Merged
merged 27 commits into from
Jul 9, 2024
Merged

feat(documentation): implement new docs styles and webfonts #3161

merged 27 commits into from
Jul 9, 2024

Conversation

oliverschuerch
Copy link
Contributor

No description provided.

@oliverschuerch oliverschuerch requested a review from a team as a code owner June 19, 2024 13:33
@oliverschuerch oliverschuerch linked an issue Jun 19, 2024 that may be closed by this pull request
Go trough Storybook & indentify Potential #2852
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fd31a54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jun 19, 2024 •
edited
Loading

Related Previews

@oliverschuerch oliverschuerch force-pushed the feat/2852-go-trough-storybook--indentify-potential branch 2 times, most recently from bce0afa to 6bc4624 Compare June 20, 2024 08:39
@oliverschuerch oliverschuerch force-pushed the feat/2852-go-trough-storybook--indentify-potential branch from 6bc4624 to ecff805 Compare June 20, 2024 08:48
@oliverschuerch oliverschuerch requested a review from gfellerph June 24, 2024 06:14
@oliverschuerch
Copy link
Contributor Author

We've decided to go with "FiraCode" and "Reddit Mono".
I will remove the ohter fonts and update the PR.

alizedebray
alizedebray approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've seen some little things:

  • The control table is truncated at the bottom:
    image
  • Alerts within the control table are quite big:
    image
  • It would be good to round the tabs on hover as well:
    image

@oliverschuerch oliverschuerch dismissed gfellerph’s stale review July 8, 2024 08:43

CR's have been fixed!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oliverschuerch oliverschuerch merged commit 580825a into main Jul 9, 2024
9 checks passed
@oliverschuerch oliverschuerch deleted the feat/2852-go-trough-storybook--indentify-potential branch July 9, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alizedebray alizedebray alizedebray approved these changes

@rouvenpost rouvenpost Awaiting requested review from rouvenpost

@gfellerph gfellerph Awaiting requested review from gfellerph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go trough Storybook & indentify Potential
4 participants
@oliverschuerch @swisspost-bot @gfellerph @alizedebray