Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): invalid message on card-control #2978

Merged
merged 14 commits into from
Jul 16, 2024
Merged

feat(styles): invalid message on card-control #2978

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
70934dd
feat(styles): card-control invalid message and icon
davidritter-dotcom Apr 18, 2024
e6af759
feat(styles): fix linting issues
davidritter-dotcom Apr 23, 2024
3517f43
Merge branch 'main' into 2625-create-form-control-invalid-message-css…
davidritter-dotcom Apr 30, 2024
e6b234e
fix(documentation): invalid message fix on card-control story
davidritter-dotcom Apr 30, 2024
a092c3e
fix(documentation): fix display invalid feedback on standard html
davidritter-dotcom May 2, 2024
c5544e6
Merge branch 'main' into 2625-create-form-control-invalid-message-css…
davidritter-dotcom Jun 4, 2024
17a7092
feat(components, styles): change request and add changeset
davidritter-dotcom Jun 4, 2024
aaad71c
Merge branch 'main' into 2625-create-form-control-invalid-message-css…
davidritter-dotcom Jun 4, 2024
a5b9400
Merge branch 'main' into 2625-create-form-control-invalid-message-css…
davidritter-dotcom Jun 12, 2024
3cd8e08
feat(documentation, styles): change requests
davidritter-dotcom Jun 13, 2024
cd3c421
fix(styles): fix code smell
davidritter-dotcom Jun 13, 2024
56da9fa
feat(styles): change invalid icon
davidritter-dotcom Jul 3, 2024
ef0956c
Merge branch 'main' into 2625-create-form-control-invalid-message-css…
davidritter-dotcom Jul 10, 2024
9c095e2
Merge branch 'main' into 2625-create-form-control-invalid-message-css…
davidritter-dotcom Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions ...mentation/src/stories/components/forms/card-control/web-component/card-control.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,14 +160,13 @@ export const FormIntegration: Story = {
parameters: {
docs: {
controls: {
include: ['disabled fieldset', 'value', 'disabled'],
include: ['disabled fieldset', 'value', 'disabled', 'group validity'],
},
},
},
args: {
name: 'checkbox',
checkboxFieldset: false,
validity: 'null',
radioValue: '',
radioDisabled: '',
radioFieldset: false,
Expand Down Expand Up @@ -196,11 +195,6 @@ export const FormIntegration: Story = {
category: 'Checkbox',
},
},
validity: {
table: {
category: 'Checkbox',
},
},
radioValue: {
name: 'value',
description: 'Set the value **prefix** of the `radio` cards.',
Expand Down Expand Up @@ -232,7 +226,7 @@ export const FormIntegration: Story = {
},
},
radioValidity: {
name: 'validity',
name: 'group validity',
description:
'Defines the validation `validity` of the control. To reset validity to an undefiend state, simply remove the attribute from the control.',
control: {
Expand Down Expand Up @@ -266,7 +260,7 @@ export const FormIntegration: Story = {

const invalidFeedback = html`<p
id="radio-group-invalid-feedback"
class="d-block invalid-feedback"
class="d-inline-flex invalid-feedback"
>
Invalid feedback
</p>`;
Expand Down
37 changes: 35 additions & 2 deletions packages/styles/src/components/form-validation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,13 @@
@use './../variables/components/form-validation';
@use './../variables/components/forms';
@use './../variables/spacing';
@use './../variables/type';
@use './../mixins/icons';

.invalid-feedback,
.valid-feedback {
display: none;
align-items: center;
width: 100%;
margin-block: form-validation.$form-feedback-margin-top 0;
padding: form-validation.$form-feedback-padding-y form-validation.$form-feedback-padding-x;
Expand All @@ -25,16 +28,46 @@
@include utilities-mx.high-contrast-mode() {
padding-inline: 0;
}

&::before {
content: '';
height: form-validation.$form-feedback-font-size * type.$line-height-copy;
width: form-validation.$form-feedback-font-size * type.$line-height-copy;
display: inline-block;
margin-right: spacing.$size-mini;
}
}

.invalid-feedback {
background: form-validation.$form-feedback-invalid-bg;
color: form-validation.$form-feedback-invalid-text;

&::before {
@include icons.icon(2104);
}
}

input:not([type='radio'], [type='checkbox']) ~ .invalid-feedback::before,
textarea ~ .invalid-feedback::before {
display: none;
}

.valid-feedback {
background: form-validation.$form-feedback-valid-bg;
color: form-validation.$form-feedback-valid-text;

&::before {
@include icons.icon(2105);
}
}

input:not([type='radio'], [type='checkbox']) ~ .valid-feedback::before,
textarea ~ .valid-feedback::before {
display: none;
}

post-card-control ~ .invalid-feedback {
display: inline-flex;
davidritter-dotcom marked this conversation as resolved.
Show resolved Hide resolved
}

.valid-feedback.custom-feedback {
Expand All @@ -48,7 +81,7 @@
@include b.form-validation-state-selector($state) {
~ .#{$state}-feedback,
~ .#{$state}-tooltip {
display: block;
display: inline-flex;
}
}

Expand Down Expand Up @@ -93,7 +126,7 @@

.is-invalid ~ .invalid-feedback,
.is-valid ~ .valid-feedback {
display: block;
display: inline-flex;
}

.form-control,
Expand Down
Loading