Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intranet-header): "tabIndex" should only be declared on interactive elements #2834

Merged
merged 10 commits into from
Apr 2, 2024
Merged

fix(intranet-header): "tabIndex" should only be declared on interactive elements #2834

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6a8983b
chore(demo, intranet-header-workspace): Refactor intranet-header demo
imagoiq Mar 20, 2024
8cf557b
Fix missing linting project
imagoiq Mar 20, 2024
3c3adb8
Fix removing intranet-header project
imagoiq Mar 20, 2024
e065431
Add iframe title for accessibility
imagoiq Mar 20, 2024
5e8bb45
Remove empty styles.scss
imagoiq Mar 20, 2024
5b8f281
Fix path for linting
imagoiq Mar 20, 2024
29944b9
Fix path for linting
imagoiq Mar 20, 2024
226ab66
Add missing .eslintrc
imagoiq Mar 20, 2024
a460d01
fix(intranet-header): "tabIndex" should only be declared on interacti…
imagoiq Mar 20, 2024
6eaaf3e
Merge branch 'main' into fix/2829-intranet-header-tabindex-interactiv…
imagoiq Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/polite-starfishes-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@swisspost/design-system-intranet-header': minor
'@swisspost/design-system-documentation': minor
'@swisspost/design-system-styles': minor
'@swisspost/design-system-demo': minor
---

Changed mobile navigation trigger to make it more accessible by default using a button element.
Comment on lines +2 to +8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know which package to involve.

It's a minor I think because it's a good change on the behavior. This is not a breaking change. Without a button, the layout is slightly changed to have a smaller padding, but it is still usable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok for this change.

34 changes: 30 additions & 4 deletions packages/demo/src/app/app-routing.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,24 @@ import { StepperDemoPageComponent } from './post-sample/components/stepper/stepp
import { DatatableDemoPageComponent } from './post-sample/components/datatable/datatable-demo-page/datatable-demo-page.component';
import { FormsDemoPageComponent } from './post-sample/components/forms/forms-demo-page/forms-demo-page.component';
import { PostCardsDemoPageComponent } from './post-sample/components/post-cards/post-cards-demo-page/post-cards-demo-page.component';
import { LayoutContainerComponent } from './layout-container/layout-container.component';
import { IntranetHeaderDemoRegularComponent } from './intranet-layout/components/intranet-header-demo-regular/intranet-header-demo-regular.component';
import { IntranetHeaderDemoBigSidebarComponent } from './intranet-layout/components/intranet-header-demo-big-sidebar/intranet-header-demo-big-sidebar.component';
import { IntranetHeaderDemoSmallSidebarComponent } from './intranet-layout/components/intranet-header-demo-small-sidebar/intranet-header-demo-small-sidebar.component';
/* tslint:enable:max-line-length */

const routes: Routes = [
{ path: '', redirectTo: 'home', pathMatch: 'full' },
{ path: 'home', component: HomeComponent, data: { fullWidth: true } },
{
path: 'home',
component: LayoutContainerComponent,
data: { fullWidth: true },
children: [{ path: '', component: HomeComponent, data: { fullWidth: true } }],
},

{
path: 'bootstrap-samples',
component: LayoutContainerComponent,
children: [
{ path: 'accordion', component: AccordionDemoPageComponent },
{ path: 'alerts', component: AlertDemoPageComponent },
Expand Down Expand Up @@ -90,6 +100,7 @@ const routes: Routes = [
},
{
path: 'ng-bootstrap-samples',
component: LayoutContainerComponent,
children: [
{ path: 'accordion', component: NgbAccordionDemoPageComponent },
{ path: 'rating', component: NgbRatingDemoPageComponent },
Expand All @@ -114,6 +125,7 @@ const routes: Routes = [
},
{
path: 'post-samples',
component: LayoutContainerComponent,
children: [
{ path: 'accordion', component: AccordionDemoPageComponent },
{ path: 'datatable', component: DatatableDemoPageComponent },
Expand All @@ -135,10 +147,24 @@ const routes: Routes = [
{ path: 'custom-select', component: CustomSelectDemoPageComponent },
{ path: 'stepper', component: StepperDemoPageComponent },
{ path: 'forms', component: FormsDemoPageComponent },
{ path: 'intranet-layout', component: IntranetLayoutComponent, data: { fullWidth: true } },
],
},

{
path: 'samples',
children: [
{
path: 'intranet-layout',
component: IntranetLayoutComponent,
data: { fullWidth: true },
path: 'intranet-layout-regular',
component: IntranetHeaderDemoRegularComponent,
},
{
path: 'intranet-layout-sidebar-big-sidebar',
component: IntranetHeaderDemoBigSidebarComponent,
},
{
path: 'intranet-layout-sidebar-small-sidebar',
component: IntranetHeaderDemoSmallSidebarComponent,
},
],
},
Expand Down
Loading
Loading