Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): Links to new icons documentation are broken #2402

Merged
merged 2 commits into from
Jan 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/witty-ways-leave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-demo': patch
---

Fixed links to new icons documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it looks, like we should switch the links:
brand new icons documentation: links over to the icon search, not to the getting started page
discover the new icons: links over to the getting started page, not to the icon search.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is

Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ <h2 class="h5">We have something new for you!</h2>
switch to the brand new icon component
<code>post-icon</code>
today. Go ahead and have a look at the
<a href="https://next.design-system.post.ch/?path=/docs/icons-search-for-icons--docs">
<a href="https://next.design-system.post.ch/?path=/docs/components-icons-getting-started--docs">
brand new icons documentation
</a>
featuring a search and over 800 icons.
</p>
<p class="mt-3">
<a
href="https://next.design-system.post.ch/?path=/docs/icons-search-for-icons--docs"
href="https://next.design-system.post.ch/?path=/docs/components-icons-search-for-icons--docs"
class="btn btn-primary"
>
Discover the new icons
Expand Down
Loading