Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles: optimize switch styles #853

Closed
7 tasks
gfellerph opened this issue Dec 7, 2022 · 1 comment
Closed
7 tasks

Styles: optimize switch styles #853

gfellerph opened this issue Dec 7, 2022 · 1 comment
Labels
🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem 📦 styles Related to the @swisspost/design-system-styles package
Milestone
Design V1

Comments

@gfellerph
Copy link
Member

gfellerph commented Dec 7, 2022 •
edited by imagoiq
Loading

Implement the updated switch design.

The new design uses a color change on the background instead of a sliding track animation and adds a smaller variant.

Figma: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components?node-id=7777%3A33877&t=zTAKJLbklgpXEsSf-1

Tasks
Preview Give feedback
@gfellerph gfellerph added the 📦 styles Related to the @swisspost/design-system-styles package label Dec 7, 2022
@gfellerph gfellerph moved this to 📋 Backlog in Design System Production Board Dec 7, 2022
@gfellerph gfellerph added this to the Styles v5.1 milestone Dec 7, 2022
@gfellerph gfellerph moved this from 📋 Backlog to 🔖 Ready in Design System Production Board Feb 2, 2023
@gfellerph gfellerph mentioned this issue Feb 28, 2023
Closed
@gfellerph gfellerph mentioned this issue Aug 7, 2023
Closed
@gfellerph gfellerph moved this from 🔖 Ready to 📋 Backlog in Design System Production Board Aug 8, 2023
@imagoiq imagoiq mentioned this issue Sep 26, 2023
Merged
imagoiq added a commit that referenced this issue Oct 2, 2023
@imagoiq @alizedebray @oliverschuerch
chore(styles): re-apply mask icon changes for form-checks (#2000)
a144769 
Snapshots URLs for comparison:

- Switch on
[preview](https://preview-2000--swisspost-design-system-next.netlify.app/iframe.html?id=snapshots--switch&viewMode=story)
|
[next-design-system](https://next.design-system.post.ch/iframe.html?id=snapshots--switch&viewMode=story)
- Checkbox on
[preview](https://preview-2000--swisspost-design-system-next.netlify.app/iframe.html?id=snapshots--checkbox&viewMode=story)
|
[next.design-system](http://localhost:9200/iframe.html?id=snapshots--checkbox&viewMode=story)
- Radio on
[preview](https://preview-2000--swisspost-design-system-next.netlify.app/iframe.html?id=snapshots--radio&viewMode=story)
|
[next.design-system](https://next.design-system.post.ch/iframe.html?id=snapshots--radio&viewMode=story)

Note:

- Switch styles is not exactly the same as in the mockup as there is
another task to tackle the design update work:
#853
- Validation error color on dark background and on checkbox +radio are
different from the main branch. To me, it looks like a bug (especially
when you click on the checkbox)

I think this PR should closes #1606

---------

Co-authored-by: Alizé Debray <[email protected]>
Co-authored-by: Alizé Debray <[email protected]>
Co-authored-by: Oliver Schürch <[email protected]>
@gfellerph gfellerph mentioned this issue Jan 24, 2024
Closed
@imagoiq imagoiq mentioned this issue Feb 22, 2024
Merged
imagoiq added a commit that referenced this issue Feb 29, 2024
@imagoiq
fix(styles): Color-contrast on form elements valid form-feedback (#2717)
3c266b6 
I didn't remove color-contrast rules for several elements, as it will be
handled on other tickets:
* Radio and checkbox:
#2681
* Switch: #853
* Textarea: #1055
@oliverschuerch oliverschuerch self-assigned this Apr 3, 2024
@oliverschuerch oliverschuerch moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Apr 3, 2024
@oliverschuerch oliverschuerch moved this from 🏗 In progress to 📋 Backlog in Design System Production Board Apr 5, 2024
@oliverschuerch oliverschuerch removed their assignment Apr 18, 2024
@gfellerph gfellerph mentioned this issue Apr 18, 2024
Closed
@gfellerph gfellerph added the 🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem label Jul 15, 2024
@gfellerph
Copy link
Member Author

Closing as obsolete

@github-project-automation github-project-automation bot moved this from 🗃️ Ready for design to 🚀 Done in Design System Production Board Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
Design V1
Development

No branches or pull requests
2 participants
@gfellerph @oliverschuerch