Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: UX review of CSS components #1266

Closed
17 of 22 tasks
Tracked by #2888
gfellerph opened this issue Mar 17, 2023 · 3 comments
Closed
17 of 22 tasks
Tracked by #2888

Storybook: UX review of CSS components #1266

gfellerph opened this issue Mar 17, 2023 · 3 comments
Assignees
Labels
📦 documentation Related to the @swisspost/design-system-documentation package

Comments

@gfellerph
Copy link
Member

gfellerph commented Mar 17, 2023

The basic HTML components are migrated to storybook and require UX review. Here is a list of all components to review. If one component requires more discussion or has open todos, the task list entry can be converted to an issue which can be handled individually.

Also have a look at the tracker ticket to see if there are any open tasks or known issues.

What to look for:

  • Are there general issues with the component, does it look good?
  • Does this component exist in Figma?
  • Does it have the same name?
  • Are hover, focus and disabled states (if applicable) in sync?
  • Does the component have the same variants?
  • Do the variants have the same name?

Foundation

Preview Give feedback

Utilities

Preview Give feedback

After a component has been reviewed, check the task as completed or close the ticket assigned to it. We can then replace the label with stable and update the status in the Component Status Tracker.

@gfellerph gfellerph added the 📦 documentation Related to the @swisspost/design-system-documentation package label Mar 17, 2023
@wueestd wueestd assigned wueestd and unassigned wueestd Mar 20, 2023
@wueestd wueestd removed their assignment Jul 25, 2023
@wueestd wueestd moved this from 📋 Backlog to 🔖 Ready in Design System Production Board Jul 25, 2023
@wueestd wueestd self-assigned this Jul 25, 2023
@wueestd wueestd moved this from 🔖 Ready to 📋 Backlog in Design System Production Board Jul 25, 2023
@wueestd wueestd removed their assignment Sep 19, 2023
@wueestd wueestd changed the title Storybook UX review of CSS components Storybook: UX review of CSS components Sep 19, 2023
@github-actions github-actions bot added the stale label Feb 14, 2024
@gfellerph gfellerph removed the stale label Mar 1, 2024
@rouvenpost
Copy link

rouvenpost commented Mar 12, 2024

Ticket Storybook: UX review of CSS components #1266

  • Typography:
    What is the Monospaced Font used for here? License?
  • Add Description use of Monospaced Fonts
  • Responsive font size:
    There are still 17px / 13px Fonts here.
  • Check Figma Font Curves in Figma
  • Direkt Sass... Update
  • Color
  • Green Success..
  • Alpha White and Alpha Black is missing
  • Dark and Bright Accesscolors should be in Fade Out.
  • Button
    No Accent Colors allowed
    The Success Button Font should be white.

  • Cards:

  • From my Perspective we mix Teasers with Cards here.
  • The Product Cards missing the Price Blue/Infoblu...
  • Checkbox
    It seems the Hover State is not accordingly to the Figma behaviour.

  • Radio Button
    It seems the Hover State is not accordingly to the Figma behaviour.

  • Range
    Knob has no Hover State. Focus State has wrong color.

  • Topic Teaser
    The Topic Teaser should only be on Yellow and Dark Grey BGs. No Accent colors.
    Keep the Dark Light add the Postyellow.

@rouvenpost rouvenpost moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Mar 12, 2024
@rouvenpost rouvenpost moved this from 🏗 In progress to 👀 In review in Design System Production Board Mar 12, 2024
@oliverschuerch
Copy link
Contributor

@gfellerph could you please have a look into this ticket and tell us, what to do next?

@gfellerph
Copy link
Member Author

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Production Board Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 documentation Related to the @swisspost/design-system-documentation package
Projects
Development

No branches or pull requests

4 participants