Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Repository::save to accept an Item instead of an ItemDocument #55

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Jul 11, 2019

Description

See title.

Motivation and context

This change is based on feedback on the last (0.19.0) release. It removes the need to wrap the Item in an ItemDocument before giving it to the Repository. In 99% of the times you simply wrap the Item in an ItemDocument and directly pass it to the Repository. So the Repository can just as well do it for you making the implementing code cleaner.

How has this been tested?

Tested using updated unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

This removes the need to wrap the Item in an ItemDocument before giving it to the Repository. In 99% of the times you simply wrap the Item in an ItemDocument and directly pass it to the Repository. So the Repository can just as well do it for you.
@JaZo JaZo merged commit 257824b into master Jul 11, 2019
@JaZo JaZo deleted the feature/change-repository-save branch July 11, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant