Change Repository::save to accept an Item instead of an ItemDocument #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title.
Motivation and context
This change is based on feedback on the last (0.19.0) release. It removes the need to wrap the Item in an ItemDocument before giving it to the Repository. In 99% of the times you simply wrap the Item in an ItemDocument and directly pass it to the Repository. So the Repository can just as well do it for you making the implementing code cleaner.
How has this been tested?
Tested using updated unit tests.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.