Two bugfixes #507
Open
Two bugfixes #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for taking the time to make a PR. Do you think you can make a fiddle with a demonstration of the problem so I can also test to see how things go with right click? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Thank you for your nice plug-in!
I use your plug-in as delegated pattern with left click option, and found that a function to disable
menu (by passing false as an argument) and a function to destroy menu (by passing'destroy' as an argument) do not work in the case of delegated pattern.
Here is a PR to fix them though I am not sure that it is a right way.
About the first issue, I fixed it in the case of left click option, but have no idea in defaul case (right click).