add test case for webpack 5

swimmadude66 · May 12, 2019 · e70673b · e70673b
1 parent d7c9113
commit e70673b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,14 +1,13 @@
 language: node_js
 node_js:
   - "8"
-  - "9"
   - "10"
-  - "11"
   - "12"
 
 env:
   - WEBPACK_VERSION=4 HTML_PLUGIN_VERSION=3
   - WEBPACK_VERSION=4 HTML_PLUGIN_VERSION=next
+  - WEBPACK_VERSION=5.0.0-alpha.12 HTML_PLUGIN_VERSION=next
 
 install: 
   - npm install

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "webpack-nomodule-plugin",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "a plugin for html-webpack-plugin to label certain chunks as legacy-only via the nomodule attribute",
   "main": "dist/plugin.js",
   "scripts": {

diff --git a/src/plugin.ts b/src/plugin.ts
@@ -1,9 +1,14 @@
 import * as HtmlWebpackPlugin from 'html-webpack-plugin';
 import * as minimatch from 'minimatch';
 
+export type NoModuleConfig = {
+    filePatterns: string[];
+    // in case I want to add other optional configs later without breaking old uses
+}
+
 export class WebpackNoModulePlugin {
 
-    constructor(private _config: {filePatterns: string[]} = {filePatterns: []}) {
+    constructor(private _config: NoModuleConfig = {filePatterns: []}) {
 
     }
 
@@ -21,9 +26,9 @@ export class WebpackNoModulePlugin {
                             return cb(null, data);
                         }
                     )
-                } else if (HtmlWebpackPlugin && HtmlWebpackPlugin['getHooks']) {
+                } else if (HtmlWebpackPlugin && HtmlWebpackPlugin.getHooks) {
                     // html-webpack 4
-                    const hooks = (HtmlWebpackPlugin as any).getHooks(compilation);
+                    const hooks = HtmlWebpackPlugin.getHooks(compilation);
                     hooks.alterAssetTags.tapAsync(
                         'NoModulePlugin',
                         (data, cb) => {