Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix d3-shape typing and package #1621

Merged
merged 2 commits into from
May 12, 2021
Merged

fix d3-shape typing and package #1621

merged 2 commits into from
May 12, 2021

Conversation

Hypercubed
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

  • d3-shape was not included as a dep in the released package
  • ngx-charts was using an incorrect type for curves

What is the new behavior?

  • @types/d3-shape is now a dependecy
  • now using correct type for curves

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@Hypercubed Hypercubed merged commit 3a506dd into master May 12, 2021
@Hypercubed Hypercubed deleted the fix/d3-shape_types branch May 12, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants