AH-436: update library #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: repair lint
jeanmurillo95
requested review from
candradeg,
daniel-hume,
youngcm2 and
Fernavarro21
youngcm2
requested review from
a team and
DanStory
and removed request for
a team
DanStory
requested changes
Aug 31, 2022
DanStory
reviewed
Aug 31, 2022
DanStory
reviewed
Sep 1, 2022
DanStory
requested changes
Sep 2, 2022
DanStory
requested changes
Sep 7, 2022
There was a problem hiding this comment.
There is unaddressed comments, make sure to unhide all comments on the Conversation tab
| @@ -144,7 +145,7 @@ export class MongoRepository<DOC, DTO = DOC> { | |||
| const eventResult = await this.invokeEvents(PRE_KEY, [RepoOperation.save, RepoOperation.create], document); | |||
| const res = await collection.insertOne(eventResult); | |||
|
|
|||
| let newDocument = this.toggleId(res.ops[0], false); | |||
| let newDocument = this.toggleId({ id: res.insertedId }, false); | |||
There was a problem hiding this comment.
This needs to be the whole document, not just the id.
|
@jeanmurillo95 there appear to still be several unresolved comments from the last review. |
|
@MatthewEppelsheimer @DanStory Can you please look at this PR? |
DanStory
requested changes
Sep 28, 2022
| } | ||
| let ourCollection; | ||
| try { | ||
| ourCollection = await db.collection(this.options.name); |
There was a problem hiding this comment.
This is missing { strict: true } so it doesn't create the collection out right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surf-shop Change Request
Change Comments
I updated the mongodb library, I also changed some methods and test cases.
Solution description
I updated the mongodb package, I reduced the complexity in some functions, repair some test cases and lint errors.
Linting & unit tests ev
idenceChecklist
PR is ready for code review and approval when each box is checked.
All steps are required, when applicable.
Strikeoutformatting indicates a step is not applicable to this change set.