Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Combine instead of OpenCombine where possible #39

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Jul 12, 2020

@ddddxxx with conditional dependencies available in Swift 5.3 I think this resolves the issue that you mentioned in TokamakUI/Tokamak#170. The binary size is only reduced from 23 MB to 21 MB though, I expected a bit more...

@MaxDesiatov MaxDesiatov added the dependencies Updates to the project dependencies label Jul 12, 2020
@MaxDesiatov MaxDesiatov marked this pull request as ready for review July 12, 2020 21:13
@MaxDesiatov MaxDesiatov merged commit d565f69 into main Jul 12, 2020
@MaxDesiatov MaxDesiatov deleted the use-combine branch July 12, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates to the project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant