Fix carton dev crashing with SO sanitizer
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
added
bug
j-f1
previously approved these changes
May 23, 2021
MaxDesiatov
commented
May 23, 2021
| loadingMessage: "Compiling...", | ||
| parser: DiagnosticsParser(), | ||
| parser: nil, |
There was a problem hiding this comment.
FYI @carson-katri I'm disabling this parser for now since it sometimes fails to parse project errors, but lets through the GTK warning. This causes confusing diagnostic messages as reported in #241. A better long-term solution would be to implement #181 instead, I hope to get to it at some point, unless someone else is willing to take this over.
MaxDesiatov
force-pushed
the
fix-sanitizer-rebuild
branch
from
ffd3a27
to
63e25f8
Compare
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the file we need to include with the build to enable the stack overflow sanitizer was written as a temporary file. This didn't happen though on watcher rebuilds with
carton devand caused crashes when a code line containingtry!relying on this file to be present was executed.I think it's easier and more efficient to bundle this file in the
static.zipfile that already includes our JS entrypoints. We requirestatic.zipto be downloaded and unpacked successfully into~/.carton/staticbefore every build anyway. It makes more sense to sense the sanitizer file in~/.carton/static/so_sanitizer.wasmand use that instead writing and deleting it at a temporary path on every build.I've also updated the JSKit dependency and cleaned up some linter warnings by moving large tuple values into a separate
BuildDescriptiontype.