Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/carton test --environment defaultbrowser #209

Merged
merged 6 commits into from
Jan 10, 2021
Merged

ci/carton test --environment defaultbrowser #209

merged 6 commits into from
Jan 10, 2021

Conversation

thecb4
Copy link
Contributor

@thecb4 thecb4 commented Jan 9, 2021

Validating that the tests perform on GitHub Actions without additional steps before formal request.

@thecb4 thecb4 marked this pull request as ready for review January 9, 2021 16:24
@thecb4 thecb4 added the continuous integration Continuous integration changes label Jan 9, 2021
@thecb4 thecb4 requested a review from a team January 9, 2021 16:40
@thecb4
Copy link
Contributor Author

thecb4 commented Jan 9, 2021

This pull request is in support of #99

MaxDesiatov
MaxDesiatov reviewed Jan 9, 2021
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@thecb4 thecb4 requested a review from a team January 9, 2021 21:02
MaxDesiatov
MaxDesiatov approved these changes Jan 9, 2021
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🙌

@thecb4 thecb4 merged commit 794eb9f into swiftwasm:main Jan 10, 2021
@thecb4 thecb4 deleted the ci/carton-test-environment-defaultbrowser branch January 10, 2021 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
continuous integration Continuous integration changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecb4 @MaxDesiatov