Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of binaries with .wasm extension #148

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Fix handling of binaries with .wasm extension #148

merged 1 commit into from
Oct 30, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

Latest toolchains produce binaries with the .wasm extension which carton can't handle yet.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Oct 30, 2020
@MaxDesiatov MaxDesiatov requested review from kateinoigakukun and a team October 30, 2020 16:30
@kateinoigakukun
Copy link
Member

I searched a way to get produced product binary path in SwiftPM command interface, but I couldn't find it 😢

@MaxDesiatov
Copy link
Collaborator Author

Yeah, not great there isn't one 😕

@MaxDesiatov MaxDesiatov merged commit b1f01a4 into main Oct 30, 2020
@MaxDesiatov MaxDesiatov deleted the wasm-extension branch October 30, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @kateinoigakukun