Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message output #142

Merged
merged 9 commits into from
Oct 26, 2020
Merged

Fix error message output #142

merged 9 commits into from
Oct 26, 2020

Conversation

carson-katri
Copy link
Member

Previously, an error message such as:

 ERROR   invalid redeclaration of 'resolve(in:)'
  58 |    public func resolve(in environment: EnvironmentValues) -> _Font {

would be output:

 ERROR   invalid redeclaration of 'resolve(in
  58 |    public func resolve(in environment: EnvironmentValues) -> _Font {

if the message had a colon.

@carson-katri carson-katri added the bug Something isn't working label Oct 24, 2020
@carson-katri carson-katri requested a review from a team October 25, 2020 14:09
MaxDesiatov
MaxDesiatov previously approved these changes Oct 25, 2020
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the test!

Package.swift Show resolved Hide resolved
@carson-katri
Copy link
Member Author

The testExample didn't seem to really test anything, I changed it to check the version number, but we might want to remove it?

MaxDesiatov
MaxDesiatov requested changes Oct 26, 2020
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTestManifests.swift and LinuxMain.swift also need to be deleted for test discovery to work.

@kateinoigakukun
Copy link
Member

I think we don't need to remove LinuxMain.swift. It would be helpful if following swiftpm way https://github.com/apple/swift-package-manager/blob/main/Tests/LinuxMain.swift

@MaxDesiatov
Copy link
Collaborator

MaxDesiatov commented Oct 26, 2020 •
edited
Loading

Great suggestion, I agree, keeping LinuxMain.swift with fatalError is a better option here! XCTestManifests.swift has to go though, as far as I understand.

MaxDesiatov
MaxDesiatov approved these changes Oct 26, 2020
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot 🙌

@carson-katri carson-katri merged commit 91ea98f into main Oct 26, 2020
@carson-katri carson-katri deleted the pretty-print-hotfix branch October 26, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carson-katri @kateinoigakukun @MaxDesiatov