Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carton dev stops rebuilding/reloading after error #339

Closed
MaxDesiatov opened this issue May 19, 2022 · 0 comments · Fixed by #347
Closed

carton dev stops rebuilding/reloading after error #339

MaxDesiatov opened this issue May 19, 2022 · 0 comments · Fixed by #347
Labels
bug Something isn't working

Comments

@MaxDesiatov
Copy link
Collaborator

No description provided.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label May 19, 2022
@MaxDesiatov MaxDesiatov mentioned this issue May 20, 2022
Merged
MaxDesiatov added a commit that referenced this issue May 20, 2022
@MaxDesiatov
Fix watcher breakage on failed builds (#347)
53bc06c 
After switching to `async`/`await` the value of `isBuildCurrentlyRunning` wasn't correctly reset, which led to issues. By resetting the variable in `defer` we guarantee that it will be reset even when errors are thrown.

Resolves #339.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix watcher breakage on failed builds swiftwasm/carton
1 participant
@MaxDesiatov