Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support downloading Ubuntu 20.04 SDK #114

Closed
MaxDesiatov opened this issue Sep 27, 2020 · 0 comments · Fixed by #134
Closed

Support downloading Ubuntu 20.04 SDK #114

MaxDesiatov opened this issue Sep 27, 2020 · 0 comments · Fixed by #134
Labels
bug Something isn't working

Comments

@MaxDesiatov
Copy link
Collaborator

MaxDesiatov commented Sep 27, 2020 •
edited
Loading

We currently don't check for distribution version on Linux, which means we could run on unsupported distributions, or download wrong toolchain that won't work. carton should check which Linux distribution it runs on, and then download a compatible toolchain archive for it, or notify the user about incompatibility.

Accordingly, it should check CPU architecture, as it would be great to support SwiftWasm on ARM64 Linux distributions, e.g. Raspbian after swiftwasm/swift#1854 is resolved.
@MaxDesiatov MaxDesiatov added the bug Something isn't working label Sep 27, 2020
@MaxDesiatov MaxDesiatov mentioned this issue Oct 19, 2020
Merged
MaxDesiatov added a commit that referenced this issue Oct 21, 2020
@MaxDesiatov
Fix support for Ubuntu 20.04, use GHA for SwiftLint (#134)
4635766 
Resolves #114.

As support for SwiftLint in Danger seems a bit buggy (causing duplicate warning comments sometimes), this PR calls SwiftLint through a separate action that displays warnings only in the PR diff and hopefully in better way.

* Add support for Ubuntu 20.04

* Refine formatting

* Move SwiftLint to a separate GitHub Action

* Fix linker warnings

* Remove `danger.yml` and `Dangerfile.swift`

* Remove `--strict` argument from `swiftlint.yml`

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix support for Ubuntu 20.04, use GHA for SwiftLint swiftwasm/carton
1 participant
@MaxDesiatov