PredictableMemOpts: handle mark_dependence #77040
Open
+903
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overloaded names create confusion.
Unit tests for mark_dependence support. Required to fix unsafeAddress.
|
@swift-ci test |
|
@swift-ci benchmark |
|
@swift-ci test source compatibility |
|
@swift-ci smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle mark_dependence source and base promotion.
Needed to fix
unsafeAddresswithout regressing anyPredictableMemOpttests. The goal is to allowmark_dependenceto be used generally in diagnostic passes without otherwise affecting any behavior at -Onone.This implementation is a stop-gap until the pass can be rewritten in Swift. But doing that will require changing the algorithm and making adaptations in other diagnostic passes. PredictableMemOpts has already become intractable and unmaintainable as-is. Any rewrite will need to drastically simplify the approach.