[concurrency] Implement swift_task_runOnMainActor. #77028
+311
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
gottesmm
force-pushed
the
swift_task_runOnMainActor
branch
from
0d60b99
to
2364626
Compare
|
@swift-ci smoke test |
This entrypoint is similar to swift_task_isCurrentExecutor except that it provides an ABI level option flag that enables one to configure its behavior in a backwards deployable manner via the option flag. I used this to expose at the ABI level the ability to check the current executor without crashing on failure, while preserving the current behavior of swift_task_isCurrentExecutor (which crashes on failure). I am going to use this to implement swift_task_runOnMainActor.
This routine takes a synchronous non-throwing main actor isolated closure without a result. If we are dynamically on the main actor, we just run the closure synchronously. Otherwise, we run a new task on the main actor and call the closure on that. This builds on top of the previous commit by using swift_task_isCurrentExecutor_v2 in the implementation of this function. To backwards deploy this function on Darwin, I used some tricks from libdispatch to validate that we are on the main queue.
gottesmm
force-pushed
the
swift_task_runOnMainActor
branch
from
2364626
to
0404c2e
Compare
|
@swift-ci smoke test |
|
I ripped out the backwards compatibility stuff. There is more to it and we may need some more compiler functionality or a compatibility library. |
|
but this is just for a prototype, so it makes sense to just get it done. |
ktoso
approved these changes
Oct 16, 2024
|
|
||
| SWIFT_EXPORT_FROM(swift_Concurrency) | ||
| SWIFT_CC(swift) | ||
| bool swift_task_isCurrentExecutor_v2(SerialExecutorRef executor, |
There was a problem hiding this comment.
Let's avoid a _v2 name like this, it'll show up in backtraces in crashing mode and isn't a naming we really do anywhere.
In other APIs where we did add new versions that take flags we name those ...WithFlags so I'd suggest doing the same here. (e.g. createTaskGroupWithFlags did so)
Suggested change
| bool swift_task_isCurrentExecutor_v2(SerialExecutorRef executor, | |
| bool swift_task_isCurrentExecutorWithFlags(SerialExecutorRef executor, |
| swift_task_checkIsolated(expectedExecutor); // will crash if not same context | ||
|
|
||
| // checkIsolated did not crash, so we are on the right executor, after all! | ||
| return true; | ||
| } | ||
|
|
||
| assert(checkMode == Legacy_NoCheckIsolated_NonCrashing); | ||
| assert(!options.contains(swift_task_is_current_executor_flag::Assert)); |
| *checkMode = swift_task_is_current_executor_flag( | ||
| *checkMode | swift_task_is_current_executor_flag::Assert); | ||
| } | ||
| } |
| // we instead just compile a shim in a .c file that actually calls | ||
| // swift_task_getCurrent and avoid the collision. | ||
| @_silgen_name("getCurrentTaskShim") | ||
| func _getCurrentTaskShim() -> UInt |
There was a problem hiding this comment.
Huh I see that's the problem you talked about, unfortunate but ok I guess
| @_silgen_name("swift_task_isCurrentExecutor_v2") | ||
| @usableFromInline | ||
| internal func _taskIsCurrentExecutor( | ||
| executor: Builtin.Executor, flags: UInt64) -> Bool |
There was a problem hiding this comment.
Can we put this one immediately next to the existing overload please?
ktoso
reviewed
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[concurrency] Implement swift_task_runOnMainActor.
This routine takes a synchronous non-throwing main actor isolated closure
without a result. If we are dynamically on the main actor, we just run the
closure synchronously. Otherwise, we run a new task on the main actor and call
the closure on that.
This builds on top of the previous commit by using
swift_task_isCurrentExecutor_v2 in the implementation of this function.
To backwards deploy this function on Darwin, I used some tricks from libdispatch
to validate that we are on the main queue.