Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0 🍒] [SE-0364] Relax @retroactive check to allow same-package declarations (#73512) #75079

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[6.0 🍒] [SE-0364] Relax @retroactive check to allow same-package declarations (#73512) #75079

merged 1 commit into from
Jul 9, 2024

Conversation

harlanhaskins
Copy link
Contributor

@harlanhaskins harlanhaskins commented Jul 8, 2024 •
edited by tshortli
Loading

  • Explanation: Silences the warning for retroactive conformances for declarations in the same package. This implements an approved amendment to SE-0364.
  • Scope: Influences whether diagnostics about the @retroactive attribute are emitted on a conformance declaration. With this change, fewer conformances will be diagnosed as needing @retroactive since conformances involving types from modules in the same package will no longer be considered retroactive.
  • Original PR: Relax @retroactive check to allow same-package declarations #73512
  • Risk: Low. This should generally cause a diagnostic that is new in 6.0 to be emitted less often.
  • Testing: New tests in the test suite.
  • Reviewer: @tshortli

Relax @retroactive check to allow same-package declarations (swiftlan…
6a34cd3 
…g#73512)

* Relax @retroactive check to allow same-package declarations

* Add package decls to the test too

* Fix tests

* Import test libraries publicly so I can use their conformances in public retroactive extensions
@harlanhaskins harlanhaskins requested a review from a team as a code owner July 8, 2024 21:54
@harlanhaskins harlanhaskins requested a review from tshortli July 8, 2024 21:54
@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli
Copy link
Contributor

tshortli commented Jul 9, 2024

@swift-ci test

@harlanhaskins
Copy link
Contributor Author

@swiftlang/swift-branch-managers Is this good to merge?

@tshortli tshortli changed the title [6.0 🍒] Relax @retroactive check to allow same-package declarations (#73512) [6.0 🍒] [SE-0364] Relax @retroactive check to allow same-package declarations (#73512) Jul 9, 2024
@DougGregor
Copy link
Member

@harlanhaskins go for it

@harlanhaskins harlanhaskins merged commit 784655f into swiftlang:release/6.0 Jul 9, 2024
5 checks passed
@harlanhaskins harlanhaskins deleted the hhaskins/retro-activity-6.0 branch July 9, 2024 22:39
@dnadoba dnadoba mentioned this pull request Dec 3, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshortli tshortli tshortli approved these changes

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harlanhaskins @tshortli @DougGregor