build: Add -threads variant of Wasm stdlib build #72650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test WebAssembly platform |
kateinoigakukun
force-pushed
the
pr-92b3c15ca0f4d772ecfcfa10876535d529bb69b7
branch
from
7cfecf3
to
bfb4b9b
Compare
|
@swift-ci Please test WebAssembly platform |
kateinoigakukun
force-pushed
the
pr-92b3c15ca0f4d772ecfcfa10876535d529bb69b7
branch
from
bfb4b9b
to
9bb3b02
Compare
|
@swift-ci Please test WebAssembly platform |
|
@swift-ci smoke test |
MaxDesiatov
approved these changes
Mar 29, 2024
This patch adds a `-threads` variant of the Wasm stdlib build, which has completely different ABI and target triple. Now we build non-threaded and threaded variants when `--build-wasm-stdlib` is enabled.
The WASI community is transitioning to a new naming for the "preview" version in the target triple: wasm32-wasi -> wasm32-wasip1. At this moment, we keep the old triple wasm32-wasi because it's already widely used, but we should start using the new triple threaded target. LLVM checks only if the OS field *starts* with "wasi", so "wasip1" is still considered a valid `isOSWASI()` target. See: WebAssembly/wasi-libc#478
We should enable them once WasmKit supports WASI threads.
We already have several uses of `OS=wasi` in the test suites, and the condition should match all the wasi targets regardless of the version.
kateinoigakukun
force-pushed
the
pr-92b3c15ca0f4d772ecfcfa10876535d529bb69b7
branch
from
9bb3b02
to
e73bc12
Compare
|
@swift-ci smoke test |
|
@swift-ci test WebAssembly platform |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci test WebAssembly platform |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
-threadsvariant of the Wasm stdlib build, which has completely different ABI and target triple.Now we build non-threaded and threaded variants when
--build-wasm-stdlibis enabled.