[stdlib] Start adopting noncopyable generics in the stdlib #71688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentey
added
the
swift evolution proposal needed
|
@swift-ci Please Build Toolchain macOS Platform |
Azoy
reviewed
Feb 17, 2024
| // This unavailable implementation uses the expected mangled name | ||
| // of `withMemoryRebound<T, Result>(to:capacity:_:)`, and provides | ||
| // an entry point for any binary linked against the stdlib binary | ||
| // for Swift 5.6 and older. | ||
| @available(*, unavailable) | ||
| @available(swift, obsoleted: 5.11) |
There was a problem hiding this comment.
Would it be worth putting this in LegacyABI.swift instead to clear up this file a little? (You don't have to, just adding a suggestion)
There was a problem hiding this comment.
Yes, but let's wait for the dust to settle a bit.
lorentey
force-pushed
the
noncopyable-primitives
branch
from
4d85587
to
1681dcd
Compare
|
@swift-ci please build toolchain macOS platform |
lorentey
force-pushed
the
noncopyable-primitives
branch
from
1681dcd
to
8ef149f
Compare
|
@swift-ci please build toolchain macOS platform |
1 similar comment
|
@swift-ci please build toolchain macOS platform |
lorentey
force-pushed
the
noncopyable-primitives
branch
from
405477a
to
d077efa
Compare
glessard
reviewed
Feb 23, 2024
|
@swift-ci please build toolchain macOS platform |
lorentey
force-pushed
the
noncopyable-primitives
branch
from
d077efa
to
73ffc13
Compare
|
@swift-ci please build toolchain macOS platform |
3 similar comments
|
@swift-ci please build toolchain macOS platform |
|
@swift-ci please build toolchain macOS platform |
|
@swift-ci please build toolchain macOS platform |
lorentey
force-pushed
the
noncopyable-primitives
branch
from
4cf3691
to
77b907e
Compare
|
@swift-ci please build toolchain macOS platform |
lorentey
force-pushed
the
noncopyable-primitives
branch
from
77b907e
to
0dff899
Compare
|
@swift-ci please build toolchain macOS platform |
The shame! |
lorentey
force-pushed
the
noncopyable-primitives
branch
from
0dff899
to
f70dd33
Compare
|
@swift-ci test |
|
@swift-ci please build toolchain macOS platform |
lorentey
force-pushed
the
noncopyable-primitives
branch
from
f70dd33
to
e6dd049
Compare
Azoy
reviewed
Feb 29, 2024
Azoy
reviewed
Feb 29, 2024
|
@swift-ci please build toolchain macOS platform |
|
@swift-ci smoke test |
…s a suppressible feature
|
@swift-ci smoke test |
|
@swift-ci test |
|
@swift-ci benchmark |
|
@swift-ci built toolchain macOS |
lorentey
changed the title
|
Interesting, locally I'm seeing an extra xpass that wasn't there at the last run: |
|
@swift-ci smoke test |
|
@swift-ci test |
|
@swift-ci benchmark |
|
@swift-ci build toolchain macOS |
|
Oh man, this got caught by the old duplicate allow-list entries thing again. Resolution is easy, it's just a shame these tests are Intel-only. |
|
Amusing preprocessor warning: |
|
@swift-ci test |
|
@swift-ci smoke test |
|
@swift-ci benchmark |
|
@swift-ci build toolchain macOS |
12 tasks
kavon
reviewed
Mar 19, 2024
Comment on lines
+54
to
+55
| // FIXME(NCG): Shouldn't this be also an error? | ||
| var moveOnly: MoveOnlyStruct |
There was a problem hiding this comment.
I think we just diagnose one property and stop. I guess we could diagnose all of the noncopyable properties preventing conformance 🤷🏼
This was referenced Mar 23, 2024
This was referenced Apr 6, 2024
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the copyability requirement on the type parameters of several crucial stdlib generic types and functions:
struct MemoryLayout<T: ~Copyable>struct UnsafePointer<Pointee: ~Copyable>struct UnsafeMutablePointer<Pointee: ~Copyable>struct UnsafeBufferPointer<Element: ~Copyable>struct UnsafeMutableBufferPointer<Element: ~Copyable>enum Optional<Wrapped: ~Copyable>: ~Copyableenum Result<Success: ~Copyable, Failure>: ~Copyablefunc swap<T: ~Copyable>func withExtendedLifetime<T: ~Copyable, R: ~Copyable>func withUnsafeTemporaryAllocation<T: ~Copyable, R>(generalizingRis a to do item for later)class ManagedBuffer<Header, Element: ~Copyable>(generalizingHeaderis a to do for later)struct ManagedBufferPointer<Header, Element: ~Copyable>(ditto)Except for
OptionalandResult, making the parameter non-copyable will not affect the copyability of the type itself.Notes, limitations:
_Pointerprotocol'sPointeeassociated type is no longer required to be copyable. This is a source-breaking change._Pointeris not public API, so we're hoping it'll be okay.~Copyableclauses change the mangling of generic functions defined over specific types (as opposed to protocols). This PR uses the new@_preInverseGenericsattribute to avoid having to duplicate existing entry points.UnsafeMutablePointer.initialize(to:)was originally defined to take a__sharedargument. This PR changes its new version to take aconsumingparameter.UnsafeMutableBufferPointer.initialize(at:to:)andUnsafeMutableRawPointer.initialize(as:to:).Result.mapError(_:)andResult.get()are now redefined as consuming methods.UnsafeCxx*Iteratorprotocols and changing whatever needed to be changed to support non-copyable pointees, with no regards to compatibility.