New integer protocols #3796
Merged
New integer protocols #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,14 +13,15 @@ | |||
| import SwiftShims | |||
|
|
|||
| /// Convert the given numeric value to a hexadecimal string. | |||
| public func asHex<T : Integer>(_ x: T) -> String { | |||
| return "0x" + String(x.toIntMax(), radix: 16) | |||
| public func asHex<T : FixedWidthInteger>(_ x: T) -> String { | |||
There was a problem hiding this comment.
Can’t we convert an arbitrary-width integer to hex?
|
Lots of missing doc comments in the code! |
| public func signum() -> Self { | ||
| // FIXME(integers): implement | ||
| fatalError() | ||
| if self < (0 as Self) { return -1 } |
There was a problem hiding this comment.
if these as Selfs are really needed I think there’s a compiler bug that should be reported. Otherwise we should just say 0.
There was a problem hiding this comment.
They were needed at some point, but are not now. Removed.
added 6 commits
July 29, 2016 13:31
added 5 commits
April 12, 2017 14:51
In Swift 3 shifts used to be defined on the concrete integer types, so the right-hand-side value in the shift expression could define a type for the result, as in `1 << i32` would have the type Int32. Swift 4 makes shift operators heterogeneous, so now `1 << i32` will result in an Int, according to the type of the left-hand-side value, which gets a default type for integer literals.
|
apple/swift-xcode-playground-support#13 |
|
@swift-ci Please benchmark |
|
Build failed |
Build comment file:Optimized (O) Regression (42)
Improvement (18)
No Changes (231)
Regression (33)
Improvement (8)
No Changes (250)
|
|
apple/swift-xcode-playground-support#13 |
|
swiftlang/swift-corelibs-foundation#951 |
|
apple/swift-xcode-playground-support#13 |
|
apple/swift-xcode-playground-support#13 |
|
swiftlang/swift-corelibs-foundation#951 |
moiseev
changed the title
|
W00t! |
|
@moiseev https://github.com/dabrahams/swift/tree/integer-merge is the beginning of a merge into the unicode-rethink branch. Everything seems good except for AlternateIntegerWidths.swift.gyb, which you can experiment with in isolation if you like: https://gist.github.com/dabrahams/f7fa2b710b50340e168926842515de4b. Update: I removed that file and made more progress, but will still likely need your help. AlternateIntegerWidths is still interesting as a backward-compatibility corner case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on integers from @moiseev
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.