Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build-script] Add sanitizer options to sourcekit-lsp #31015

Merged
merged 1 commit into from
Apr 28, 2020
Merged

[build-script] Add sanitizer options to sourcekit-lsp #31015

merged 1 commit into from
Apr 28, 2020

Conversation

benlangmuir
Copy link
Contributor

For now, default to no sanitizers.

@benlangmuir
[build-script] Add sanitizer options to sourcekit-lsp
5eb1432 
For now, default to no sanitizers.
@benlangmuir
Copy link
Contributor Author

@swift-ci please smoke test

@benlangmuir
Copy link
Contributor Author

swiftlang/sourcekit-lsp#263
preset=buildbot_sourcekitlsp_macos,sanitize
@swift-ci please test with preset macOS

@benlangmuir
Copy link
Contributor Author

swiftlang/sourcekit-lsp#263
preset=buildbot_sourcekitlsp_linux,sanitize
@swift-ci please test with preset Linux

@benlangmuir
Copy link
Contributor Author

Linux:

==105142==You are trying to dlopen a /home/buildnode/jenkins/workspace/swift-PR-Linux-preset/branch-master/buildbot_incremental/toolchain-linux-x86_64/usr/lib/libsourcekitdInProc.so shared library with RTLD_DEEPBIND flag which is incompatibe with sanitizer runtime (see https://github.com/google/sanitizers/issues/611 for details). If you want to run /home/buildnode/jenkins/workspace/swift-PR-Linux-preset/branch-master/buildbot_incremental/toolchain-linux-x86_64/usr/lib/libsourcekitdInProc.so library under sanitizers please remove RTLD_DEEPBIND from dlopen flags.

@benlangmuir
Copy link
Contributor Author

swiftlang/sourcekit-lsp#269
preset=buildbot_sourcekitlsp_linux,sanitize
@swift-ci please test with preset Linux

@benlangmuir
Copy link
Contributor Author

swiftlang/sourcekit-lsp#269
preset=buildbot_sourcekitlsp_linux,sanitize
@swift-ci please test with preset Linux

1 similar comment
@benlangmuir
Copy link
Contributor Author

swiftlang/sourcekit-lsp#269
preset=buildbot_sourcekitlsp_linux,sanitize
@swift-ci please test with preset Linux

@benlangmuir
Copy link
Contributor Author

swiftlang/sourcekit-lsp#270
preset=buildbot_sourcekitlsp_linux,sanitize
@swift-ci please test with preset Linux

@benlangmuir
Copy link
Contributor Author

swiftlang/sourcekit-lsp#270
preset=buildbot_sourcekitlsp_macos,sanitize
@swift-ci please test with preset macOS

@benlangmuir benlangmuir merged commit bb89c46 into swiftlang:master Apr 28, 2020
@benlangmuir benlangmuir deleted the sk-sanitize branch April 28, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benlangmuir