Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Math functions for Swift" #23789

Closed
wants to merge 1 commit into from
Closed

Revert "Math functions for Swift" #23789

wants to merge 1 commit into from

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Apr 4, 2019

Reverts #23140

Just the test to see if this is really what introduced source compatibility regressions:

https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/3384/console

@xedin
Copy link
Contributor Author

xedin commented Apr 4, 2019

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Apr 4, 2019

Currently failing:

02:04:20   FAIL: IBAnimatable, 4.0, eb4acb, IBAnimatableApp, generic/platform=iOS
02:04:20   FAIL: IBAnimatable, 4.0, eb4acb, IBAnimatable, generic/platform=iOS
02:04:20   FAIL: Surge, 5.0, 38a328, Surge-watchOS, generic/platform=watchOS
02:04:20   FAIL: Surge, 5.0, 38a328, Surge-tvOS, generic/platform=tvOS
02:04:20   FAIL: Surge, 5.0, 38a328, Surge-macOS, generic/platform=macOS
02:04:20   FAIL: Surge, 5.0, 38a328, Surge-iOS, generic/platform=iOS
02:04:20   FAIL: Surge, 4.2, 38a328, Surge-watchOS, generic/platform=watchOS
02:04:20   FAIL: Surge, 4.2, 38a328, Surge-tvOS, generic/platform=tvOS
02:04:20   FAIL: Surge, 4.2, 38a328, Surge-macOS, generic/platform=macOS
02:04:20   FAIL: Surge, 4.2, 38a328, Surge-iOS, generic/platform=iOS
02:04:20   FAIL: SwifterSwift, 4.0, d3c3fd, SwifterSwift-watchOS, generic/platform=watchOS
02:04:20   FAIL: SwifterSwift, 4.0, d3c3fd, SwifterSwift-tvOS, generic/platform=tvOS
02:04:20   FAIL: SwifterSwift, 4.0, d3c3fd, SwifterSwift-macOS, generic/platform=macOS
02:04:20   FAIL: SwifterSwift, 4.0, d3c3fd, SwifterSwift-iOS, generic/platform=iOS

@xedin
Copy link
Contributor Author

xedin commented Apr 4, 2019

@stephentyrone @airspeedswift Math functions PR introducted multiple source compatibility regressions in external and internal projects

@tkremenek
Copy link
Member

Let's get the change reverted until we can resolve the source compatibility breaks before we land. All API changes to the Standard Library should go through the compatibility suite before merging.

@xedin
Copy link
Contributor Author

xedin commented Apr 4, 2019

Looks like this is going to be a non-trivial revert because there are conflicts already. @stephentyrone would be the best person to do that.

@stephentyrone
Copy link
Contributor

@xedin #23800

@xedin
Copy link
Contributor Author

xedin commented Apr 4, 2019

@stephentyrone thank you!

@xedin xedin closed this Apr 4, 2019
@shahmishal shahmishal deleted the revert-23140-mafs branch May 13, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants