Shims: use _hypotf on Windows rather than __builtin_hypot
#23780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, `hypotf` is an inline in MSVCRT which forwards to `_hypotf`. This repairs the Windows build.
|
CC: @stephentyrone |
|
This seems like it should eventually be fixed in the LLVM lowering of __builtin_hypotf rather than the standard library (I'm fine with taking it here as a quick fix, though). Can you file a bug against LLVM? |
|
Yeap, filed https://bugs.llvm.org/show_bug.cgi?id=41366 for that |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test Linux platform |
stephentyrone
added a commit
that referenced
this pull request
Apr 4, 2019
* Revert "Merge pull request #23791 from compnerd/you-know-nothing-clang" This reverts commit 5150981, reversing changes made to 8fc305c. * Revert "Merge pull request #23780 from compnerd/math-is-terrible" This reverts commit 2d7fedd, reversing changes made to 0205150. * Revert "Merge pull request #23140 from stephentyrone/mafs" This reverts commit 777750d, reversing changes made to 0c8920e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately,
hypotfis an inline in MSVCRT which forwards to_hypotf. This repairs the Windows build.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.