Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsiderate naming #165

Merged
merged 1 commit into from
Dec 4, 2015
Merged

Fix inconsiderate naming #165

merged 1 commit into from
Dec 4, 2015

Conversation

pcbro
Copy link
Contributor

@pcbro pcbro commented Dec 4, 2015

Fixes inconsiderate naming in test

@Jaxan
Copy link

Jaxan commented Dec 4, 2015

It is not even used as a metaphor (I am referring here to a deleted comment). One definition of slave in my dictionary is:

  • a device, or part of one, directly controlled by another: [ as modifier ] : a slave cassette deck. Compare with master1.

So, technically, it is the proper use of the word. And I think it conveys the right meaning in this context. But it's not important to me, of course.

@neilkimmett
Copy link
Contributor

Ignore the haters, I'm a fan of this change. Nice work @pcbro

@peterkellydev
Copy link

Master / Slave are perfectly acceptable words in the English language and are very well understood and widely-used term in technology. Leader / Follower as a metaphor does not describe the relationship as well. This change is objectively pointless and introduces inconsistent terminology. If you are offended by this term in some codebase then you most likely have too much time on your hands. Perhaps we can ask them to also change the name of the repo? Apple offends me and is inconsiderate because I think of Adam & Eve and the devil...

@tangentfairy-zz
Copy link

Would replica/primary be a better solution for everyone?

@HealsCodes
Copy link

I can only agree with @peterkellyonline and the comment provided by @Jaxan makes it clear that this usage is targeted at the technical application of the terms..

@s3itz
Copy link

s3itz commented Dec 4, 2015

The guys name is 'pcbro' and obviously refers to South Park. Hard to tell if this is genuine or a troll.

@clooth
Copy link

clooth commented Dec 4, 2015

He's just running stuff through Alex I think.

@ashfurrow
Copy link

If this nomenclature wasn't in Swift 2, would it be added to Swift 3?

I think it's worth considering. If leader/follower isn't the right metaphor, then find a new one.

@swizzlr
Copy link

swizzlr commented Dec 4, 2015

Quite beside the point who originated this patch. I don't object at all to "leader" or "follower", and I doubt you'll find anyone who does.

If you're objecting to the motivation of this patch, that is also quite beside the point. The Swift open source community will entirely benefit from a slightly more inclusive change in name that has no impact on development, and more to the point, by accepting this patch (and the untold hundreds of "typo" patches that went through last night) it can be publicly demonstrated that all contributions are welcome and considered on their merits alone.

@cannyboy
Copy link

cannyboy commented Dec 4, 2015

Merging into 'master'? Outrageous.

@peterkellydev
Copy link

I object to Leader / Follower because it does not describe the concept as well as Master / Slave, which everyone is familiar with. And it is perfectly acceptable terminology used as it is in a technology domain. But more importantly, just because you are offended by something doesn't mean it has to change.

@tangentfairy-zz
Copy link

Boy, that escalated quickly

@jordanekay
Copy link
Contributor

master on its own is fine. master and slave used the way they are is not.

@pilky
Copy link

pilky commented Dec 4, 2015

Yeah, removing Master/Slave terminology is certainly worthwhile. Appealing that something was ok in the past generally isn't a good enough argument to keep it (after all, the whole reason people are starting to question this terminology is because of it's relation to something that was deemed "ok" in the past, but which we no longer view as acceptable).

That said, while Leader/Follower is an improvement I'm not entirely sure it's ideal. Maybe Primary/Replica would be better.

@czechboy0
Copy link
Member

Manager/worker?

@neilkimmett
Copy link
Contributor

Even just master/worker would be fine?

@czechboy0
Copy link
Member

👍

@Rosyna
Copy link

Rosyna commented Dec 4, 2015

The English word "Master" is used in technology for a few different reasons.

  1. It is the thing that all others are created from. Like master branch, master tape, golden master.
  2. It is the thing that gets all requests/orders/dividends and then determines where something should go. This is similar to how Master works with IDE when two drives are on the same bus. See "Marshal".

Sometimes "host" is used instead of "master" (networks, USB, et cetera) as they are synonyms.

When an antonym to "master" was required to indicate a similar item that is not defined as "master", "slave" is generally chosen. Not necessarily because of the meaning of the word but because it is an antonym for most uses of the word "master".

@neilkimmett
Copy link
Contributor

Its used in a different context, but theres a lot of good discussion on this django PR django/django#2692

@jckarter
Copy link
Contributor

jckarter commented Dec 4, 2015

Looks good, thanks!

jckarter added a commit that referenced this pull request Dec 4, 2015
Change master/slave to leader/follower in test
@jckarter jckarter merged commit c2b5546 into swiftlang:master Dec 4, 2015
@swiftlang swiftlang locked and limited conversation to collaborators Dec 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.