-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set an environment variable in swift test
to indicate which testing library is in use.
#7573
Merged
grynspan
merged 3 commits into
main
from
jgrynspan/128272138-envvar-for-active-test-library
May 17, 2024
Merged
Set an environment variable in swift test
to indicate which testing library is in use.
#7573
grynspan
merged 3 commits into
main
from
jgrynspan/128272138-envvar-for-active-test-library
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… library is in use. This PR sets a new environment variable `"SWIFT_PM_TEST_LIBRARY"` to the name of the active testing library (`"XCTest"` or `"swift-testing"`.) Code in these libraries can then use the presence of this environment variable to adjust their behaviour. Resolves rdar://128272138.
grynspan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
May 17, 2024 14:45
stmontgomery
approved these changes
May 17, 2024
dennisweissmann
approved these changes
May 17, 2024
bnbarham
approved these changes
May 17, 2024
@swift-ci please test |
@swift-ci please test |
@swift-ci please test Windows |
bnbarham
reviewed
May 17, 2024
@swift-ci please test |
@swift-ci please test Windows |
grynspan
added a commit
that referenced
this pull request
May 17, 2024
…esting library is in use. (#7577) **Explanation**: Allows swift-testing and XCTest to detect at runtime which testing library SwiftPM is trying to run so that they can adjust their behaviour (e.g. `XCTestScaffold`) appropriately. **Scope**: Test build products at runtime. **Risk**: Low. No obvious risk here to adding a new environment variable nobody is looking for. **Testing**: New unit test (tested at desk, but must be temporarily disabled in CI until CI is running a version of SwiftPM that includes the change.) **Original PR**: #7573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets a new environment variable
"SWIFT_PM_TEST_LIBRARY"
to the name of the active testing library ("XCTest"
or"swift-testing"
.) Code in these libraries can then use the presence of this environment variable to adjust their behaviour.Resolves rdar://128272138.