Add isAutolink property to Link #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Ye
force-pushed
the
bugfix/kyle/custom-link-titles
branch
from
d5f82a2 to
ac1596e
Compare
|
@swift-ci please test |
3 tasks
Kyle-Ye
force-pushed
the
bugfix/kyle/custom-link-titles
branch
from
ac1596e to
2c83cf7
Compare
|
@swift-ci please test |
Kyle-Ye
force-pushed
the
bugfix/kyle/custom-link-titles
branch
from
2c83cf7 to
e24e7c6
Compare
Kyle-Ye
force-pushed
the
bugfix/kyle/custom-link-titles
branch
from
e24e7c6 to
df6944a
Compare
|
@swift-ci please test |
QuietMisdreavus
approved these changes
Mar 13, 2023
QuietMisdreavus
added a commit
that referenced
this pull request
Mar 13, 2023
This reverts commit 656cf39.
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
With swiftlang/swift-docc#376
Close swiftlang/swift-docc#271
Summary
LinkAdd a setter toLink.isAutolinkso that after updating destination of link, we can preserve the old isAutolink value.See discussion on swiftlang/swift-docc#376 (comment)
Dependencies
None
Testing
swiftlang/swift#61506
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded