[Proposal] Add isEven, isOdd, and isMultiple(of:) to BinaryInteger
#891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnamedd
reviewed
Aug 14, 2018
| # Adding `isEven`, `isOdd`, `isMultiple` to `BinaryInteger` | ||
|
|
||
| * Proposal: [SE-NNNN](NNNN-binaryinteger-iseven-isodd.md) | ||
| * Authors: [Robert MacEachern](https://robmaceachern.com), [SiliconUnicorn](https://forums.swift.org/u/siliconunicorn/summary) |
There was a problem hiding this comment.
To follow the pattern used on Swift Evolution, I would like to suggest you to use the GitHub profile url address to link the authors.
e.g:
* Authors: [Robert MacEachern](https://github.com/robmaceachern), [SiliconUnicorn](https://forums.swift.org/u/siliconunicorn/summary)There was a problem hiding this comment.
I've updated mine and have reached out to the other user to get his contact info.
tkremenek
added
the
workgroup: ready
|
This review will be scheduled to start next Monday, August 20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal adds
var isEven: Bool,var isOdd: Bool, andfunc isMultiple(of other: Self) -> Boolto theBinaryIntegerprotocol.isEvenandisOddare convenience properties for querying the parity of the integer andisMultipleis a more general function to determine whether an integer is a multiple of another integer.Swift-evolution thread: Even and Odd Integers