Skip to content

Commit

Permalink
Preview package implementation [1/3] (#1089)
Browse files Browse the repository at this point in the history
* Revise the proposal template and process documentation re: SwiftPreview

* Fix naming consistency for the preview package
  • Loading branch information
natecook1000 authored Feb 18, 2020
1 parent 05d666d commit 277df94
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
11 changes: 9 additions & 2 deletions process.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,20 @@ for the upcoming Swift release will not be brought up for review. If you can't r
* **Request a review**: initiate a pull request to the [swift-evolution repository][swift-evolution-repo] to indicate to the core team that you would like the proposal to be reviewed. When the proposal is sufficiently detailed and clear, and addresses feedback from earlier discussions of the idea, the pull request will be accepted. The proposal will be assigned a proposal number as well as a core team member to manage the review.
* **Address feedback**: in general, and especially [during the review period][proposal-status], be responsive to questions and feedback about the proposal.

## Preparing an implementation

When you are ready to request a review, a pull request with an implementation is required in addition to your proposal. Proposals that can ship as part of the [Standard Library Preview package] should be paired with a pull request against the [swift-evolution-staging repository][swift-evolution-staging]. All other proposals should be paired with an implementation pull request against the [main Swift repository](https://github.com/apple/swift).

The preview package can accept new types, new protocols, and extensions to existing types and protocols that can be implemented without access to standard library internals or other non-public features. For more information about the kinds of changes that can be implemented in the preview package, see [SE-0264](https://github.com/apple/swift-evolution/blob/master/proposals/0264-stdlib-preview-package.md).

## Review process

The review process for a particular proposal begins when a member of
the core team accepts a pull request of a new or updated proposal into
the [swift-evolution repository][swift-evolution-repo]. That core team
member becomes the *review manager* for the proposal. The proposal
is assigned a proposal number (if it is a new proposal), then enters
the review queue.
is assigned a proposal number (if it is a new proposal), and then enters
the review queue. If your proposal's accompanying implementation takes the form of a package, the review manager will merge your pull request into a new branch in the [swift-evolution-staging repository][swift-evolution-staging].

The review manager will work with the proposal authors to schedule the
review. Reviews usually last a single week, but can run longer for
Expand Down Expand Up @@ -113,6 +119,7 @@ A given proposal can be in one of several states:
write the version number for which the implementation will be complete.

[swift-evolution-repo]: https://github.com/apple/swift-evolution "Swift evolution repository"
[swift-evolution-staging]: https://github.com/apple/swift-evolution-staging "Swift evolution staging repository"
[proposal-reviews]: https://forums.swift.org/c/evolution/proposal-reviews "'Proposal reviews' category of the Swift forums"
[proposal-status]: https://apple.github.io/swift-evolution/

Expand Down
2 changes: 1 addition & 1 deletion proposal-templates/0000-swift-template.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

*During the review process, add the following fields as needed:*

* Implementation: [apple/swift#NNNNN](https://github.com/apple/swift/pull/NNNNN)
* Implementation: [apple/swift#NNNNN](https://github.com/apple/swift/pull/NNNNN) or [apple/swift-evolution-staging#NNNNN](https://github.com/apple/swift-evolution-staging/pull/NNNNN)
* Decision Notes: [Rationale](https://forums.swift.org/), [Additional Commentary](https://forums.swift.org/)
* Bugs: [SR-NNNN](https://bugs.swift.org/browse/SR-NNNN), [SR-MMMM](https://bugs.swift.org/browse/SR-MMMM)
* Previous Revision: [1](https://github.com/apple/swift-evolution/blob/...commit-ID.../proposals/NNNN-filename.md)
Expand Down

0 comments on commit 277df94

Please sign in to comment.